refactor: change predicate topic of controllers #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domire8
force-pushed
the
refactor/predicate-topic
branch
from
7e16583
to
24b3e0e
Compare
eeberhard
approved these changes
Jul 3, 2024
domire8
force-pushed
the
refactor/predicate-topic
branch
from
24b3e0e
to
8680509
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another breaking change. The predicates of controllers should be published onto the same topic as component predicates now since they have the same message type.
Next step: Only publish predicates on change!
Review guidelines
Estimated Time of Review: 2 minutes
Checklist before merging: