Common components integration tests #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
===========================================
+ Coverage 29.94% 40.11% +10.17%
===========================================
Files 12 12
Lines 688 688
===========================================
+ Hits 206 276 +70
+ Misses 482 412 -70
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
samcunliffe
approved these changes
Apr 17, 2023
Closed
1 task
|
hi @samcunliffe, re-requesting a (hopefully quick) review for the parametrised tests. also tagging @niksirbi since he has experience with fixtures inside parametrize input arguments (thanks!) Ideally I would like to have one fixture with the page name and title of all pages but didn't find a way around it... 🤔 |
samcunliffe
reviewed
May 18, 2023
Closed
Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
So it was an XPASS and we had XFAIL strict (expected fail, but found the test to pass therefore FAIL). Without strict we get an XPASS on Windows. Something to investigate further as we add more tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests to check if the components common to all pages are created. The common components are the page content container and the sidebar.
For the sidebar, we also check that clicking each link takes you to a page with the expected title.
Right now, if no config file is loaded in the Home tab, each of the subsequent pages will return an error in the browser console (see issue #81). I wrote a test for that and marked it with
xfail(expected fail) for nowCloses #27