Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common components integration tests #82

Merged
merged 19 commits into from
Jun 13, 2023
Merged

Common components integration tests #82

merged 19 commits into from
Jun 13, 2023

Commits on Apr 17, 2023

  1. add ids for sidebar and sidebar links

    @sfmig
    sfmig committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    fe769e0 View commit details
    Browse the repository at this point in the history

  2. add tests to check components common to all pages are created correctly

    @sfmig
    sfmig committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    94cdddf View commit details
    Browse the repository at this point in the history

  3. add docstring for map fixture and clean comments for review

    @sfmig
    sfmig committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6aa95f7 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. move fixtures to conftest

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    f8d4d02 View commit details
    Browse the repository at this point in the history

  2. parametrise test sidebar links

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    8cb7ebb View commit details
    Browse the repository at this point in the history

  3. add xfail for each parametrized case

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    eda18ce View commit details
    Browse the repository at this point in the history

  4. use fixture in pytest parametrize

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    97e64c2 View commit details
    Browse the repository at this point in the history

  5. add fixture to parametrize

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    0428d44 View commit details
    Browse the repository at this point in the history

  6. adding fixtures in conftest

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    fcf406d View commit details
    Browse the repository at this point in the history

  7. remove map from comftest. add question for review.

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    d748a5b View commit details
    Browse the repository at this point in the history

  8. remove commented input arg

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    7c9d8e5 View commit details
    Browse the repository at this point in the history

  9. correct type in test input args 

    Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
    @sfmig @samcunliffe
    sfmig and samcunliffe committed May 18, 2023
    Configuration menu
    Copy the full SHA
    f08c594 View commit details
    Browse the repository at this point in the history

  10. Update docstrings 

    Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
    @sfmig @samcunliffe
    sfmig and samcunliffe committed May 18, 2023
    Configuration menu
    Copy the full SHA
    01fa4b0 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into common-components-integration-tests

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    6ed9609 View commit details
    Browse the repository at this point in the history

  12. add type and docstrings for request input

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    2ce91fb View commit details
    Browse the repository at this point in the history

  13. change docstrings to numpy format

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    400e564 View commit details
    Browse the repository at this point in the history

  14. extra time for windows?

    @sfmig
    sfmig committed May 18, 2023
    Configuration menu
    Copy the full SHA
    f51e266 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Merge branch 'main' into common-components-integration-tests

    @samcunliffe
    samcunliffe committed May 19, 2023
    Configuration menu
    Copy the full SHA
    08b5efa View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. The ROI page was not sending errors on Windows. 

    So it was an XPASS and we had XFAIL strict (expected fail, but found the
test to pass therefore FAIL). Without strict we get an XPASS on Windows.
Something to investigate further as we add more tests.
    @samcunliffe
    samcunliffe committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d91f1e8 View commit details
    Browse the repository at this point in the history