Intercept KeyError on navigation straight to the metadata tab without adding a config. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves the first part (but not all of) of #83. If no config found, then just show a message explaining that there's no config loaded and return. Also the function didn't explicitly return if ``metadata_output_children`` so also fix that.
samcunliffe
commented
Jun 12, 2023
| @@ -373,6 +391,7 @@ def create_metadata_table_and_buttons( | |||
| generate_yaml_tooltip, | |||
| ] | |||
| ) | |||
| return None | |||
There was a problem hiding this comment.
Not sure if we ever get into this situation? Should I throw an error? Or return an empty Div?
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 29.81% 39.17% +9.36%
==========================================
Files 12 13 +1
Lines 691 702 +11
==========================================
+ Hits 206 275 +69
+ Misses 485 427 -58
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the first part of
If no config is found, then show a message explaining that there's no config loaded and return. Also, the function didn't explicitly return if
metadata_output_childrenso I also fix that.The eagle-eyed amongst you might notice that this is testless 🤢#WhatAboutAllOfYouTDDEvangelismSam?. But this will be covered by a tweak to one of the files introduced in #82 (which should probably go in first but not mandatory).Edit: Now ready for review (sorry for the noise). Tested and looking good. I also fixed an error on the ROI page (which now also loads without error if no config).
The dashboard is still an
XFAILand is a bit more complicated so should go in a separate PR.