[15.0] Revert "[FIX] l10n_es_aeat_mod349: origin amount incorrect" #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0e7847e.
pedrobaeza
changed the title
|
Comprobado. Así funciona. /ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
This was referenced Sep 19, 2024
|
Congratulations, your PR was merged at 6fd1600. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0e7847e.
Este parche fue metido sin advertirse en la migración a 14.0, cuando el PR original de 11.0 no estaba aprobado ni la solución estaba clara que fuera la adecuada:
y aparte de drenar rendimiento por asignar dos veces la variable
origin_amountcon mapeos que requieren obtener los datos, está provocando problemas de importes negativos.Voy a comprobar en el caso real reportado por el cliente si sale correcto sin el parche. Si es así, fusionaré y cualesquiera que fueran los problemas existentes con el anterior código, deben expresarse y parchearse por el procedimiento regular.
@Tecnativa TT50922