Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] Revert "[FIX] l10n_es_aeat_mod349: origin amount incorrect" #3743

Merged

Conversation

pedrobaeza
Copy link
Member

Forward-port de #3727 y #3729

This partially reverts commit 0e7847e, amended later by 0e93183.

Este parche fue metido sin advertirse en la migración a 14.0, cuando el PR original de 11.0 no estaba aprobado ni la solución estaba clara que fuera la adecuada:

imagen

y aparte de drenar rendimiento por asignar dos veces la variable origin_amount con mapeos que requieren obtener los datos, está provocando problemas de importes negativos. Luego más tarde en esta versión hubo una correción realizada en 0e93183, con su caso de uso, para la que se ha comprobado que una parte del código funciona, respetando esa parte.

@Tecnativa TT50922

This partially reverts commit 0e7847e,
amended later by 0e93183.
@pedrobaeza pedrobaeza added this to the 17.0 milestone Sep 29, 2024
@pedrobaeza
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-3743-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 50fb901 into OCA:17.0 Sep 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b1d9370. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants