[15.0][FIX] l10n_es_aeat_mod349: Importe original incorrecto en rectificaciones de otros periodos #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we enter refunds in another period, the rectifications section must correctly report the right amounts.
|
Hi @pedrobaeza, |
…ones de otros periodos Se crean dos facturas para mismo proveedor en un periodo, y en el siguiente periodo se hacen abonos. En el segundo periodo del 349 se observa que el importe original en rectificaciones de otros periodos es incorrecto. Está duplicado.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
|
@JordiBForgeFlow creo que el problema provenía del código incorrecto que se introdujo en la migración de 14.0 (sin ser parte de la migración), y que se está ya revirtiendo en #3727. Prueba cuando esté fusionado, y si sigues teniendo problemas, lo comentas para verlo. Por el momento, cierro aquí. |
pedrobaeza
deleted the
15.0-fix-l10n_es_aeat_mod349-fix-duplicated-original-refund-amt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relacionado con el modelo 349.
En el PR se incluye un primer commit que contiene un test que reproduce el escenario que falla. Se crean dos facturas para mismo proveedor en un periodo, y en el siguiente periodo se hacen abonos. En el segundo periodo del 349 se observa que el importe original en rectificaciones de otros periodos es incorrecto. Está duplicado.
Este primer commit falla el test.
En el segundo commit del PR se incluye la corrección. Este segundo commit ya no falla los tests.