Overload fixes and revisions #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mage, in line with RuneScape's mechanics, rather than applying it ~5 ticks after damage is received. * Make the overload buff remain active even if a player logs out, ensuring its removal only upon the expiration of the timer.
GregHib
reviewed
May 8, 2024
...ain/kotlin/world/gregs/voidps/world/interact/entity/player/combat/consume/drink/Overload.kts
Outdated
Show resolved
Hide resolved
…ness_main_multi_area` to keep the same format as other areas like it. * Add `enterArea` to `Overload.kts` to handle any scenarios where a player would enter the wilderness with any overload effect active * Add check to stop players from using an overload potion while they're in the wilderness * Remove wilderness check to apply a reduced buff while drinking an overload
|
Just to give more clarification on why i removed the ability to use overloads in the wilderness, it's because it was only after EOC where overloads were allowed to be used in the wilderness. |
|
Yeah absolutely they are far too OP to be allowed in the wilderness |
GregHib
reviewed
May 8, 2024
...ain/kotlin/world/gregs/voidps/world/interact/entity/player/combat/consume/drink/Overload.kts
Outdated
Show resolved
Hide resolved
GregHib
reviewed
May 8, 2024
...ain/kotlin/world/gregs/voidps/world/interact/entity/player/combat/consume/drink/Overload.kts
Outdated
Show resolved
Hide resolved
… overload boosts it will be reapplied once they leave. * Change parsed string for `enterArea` from `wilderness*` to `wilderness`
GregHib
reviewed
May 13, 2024
...ain/kotlin/world/gregs/voidps/world/interact/entity/player/combat/consume/drink/Overload.kts
Outdated
Show resolved
Hide resolved
...ain/kotlin/world/gregs/voidps/world/interact/entity/player/combat/consume/drink/Overload.kts
Outdated
Show resolved
Hide resolved
GregHib
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had noticed when making giant mole that the behaviour of overloads were slightly off, when applying the stats, it wasn't carrying over apon logging out, and the wilderness check would always return false.
For reference I have a video from 2009 and a forum post from 2010 for the mechanics that I changed
Video demonstrating when stats are boosted: https://youtu.be/7dmQtHVah80?si=o_PO0Emo0bF6nRfw&t=43
Forum post stating that potions don't reset when logging out, reply by user
Zaaps1: 'https://forum.tip.it/topic/254557-if-i-log-out-will-my-super-anti-posion-stop-its-effect/'