Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: only use the bootstrap js that we need #75

Merged
merged 1 commit into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified bun.lockb
Binary file not shown.
5 changes: 0 additions & 5 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@
<meta name="theme-color" content="#000000" />
<meta name="description" content="View soccer goals as they happen around the world" />
<link rel="apple-touch-icon" href="/logo192.png" />
<script
src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.2/dist/js/bootstrap.bundle.min.js"
integrity="sha384-C6RzsynM9kWDrMNeT87bh95OGNyZPhcTNXj1NW7RuBCsyN/o0jlpcV8Qyq46cDfL"
crossorigin="anonymous"
></script>
<!--
manifest.json provides metadata used when your web app is installed on a
user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
"@types/react": "^18.0.21",
"@types/react-dom": "^18.0.6",
"axios": "^0.26.1",
"bootstrap": "^5.3.2",
"popper": "^1.0.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

popper is a peer dep for the dropdown stuff in bootstrap

"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-paginate": "^8.1.3",
Expand Down
1 change: 1 addition & 0 deletions src/components/Select.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import 'bootstrap/js/dist/dropdown';
import {useState} from 'react';

interface Option {
Expand Down
Loading