perf: only use the bootstrap js that we need #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astone123
commented
Nov 30, 2023
| @@ -7,6 +7,8 @@ | |||
| "@types/react": "^18.0.21", | |||
| "@types/react-dom": "^18.0.6", | |||
| "axios": "^0.26.1", | |||
| "bootstrap": "^5.3.2", | |||
| "popper": "^1.0.1", | |||
There was a problem hiding this comment.
popper is a peer dep for the dropdown stuff in bootstrap
wweitzel
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
To check my understanding:
- Currently we are loading the entire bootstrap from a CDN. This should be pretty fast as is, and loads in parallel with our app js bundle.
- This PR makes it so that instead of loading from a CDN in parallel with with our app js, we bundle a small amount of the bootstrap directly into our app js bundle? Meaning our app js bundle becomes slightly bigger after this.
Is that right? If so, I am curious how much faster this ends up being. If you have time, would be cool to see a before/after performance metric for this somehow after we deploy.
|
@wweitzel yeah lighthouse doesn't show much of a difference in local testing as far as I can tell - bottom line is that we'll be shipping less JS to the browser though, which I think is good. No crazy performance gains though |
wweitzel
added a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading the entire bootstrap JS up front, we should use our package manager and bundler to only ship the JS that we need - in this case, the only things that we actually use the bootstrap JS for are the dropdowns, so just import the dropdown JS.