Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated create_release in favor of create_github_release #588

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Remove deprecated create_release in favor of create_github_release #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e49525d
Remove deprecated `create_release` in favor of `create_github_release`
mokagio Sep 3, 2024
e281e0c
Update `MIGRATION.md` with note regarding `create_release`
mokagio Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

- Removed `build_gradle_path` parameter from `android_current_branch_is_hotfix`. [#579]
- Deleted `Fastlane::Helper::Android::GitHelper` and `Fastlane::Helper::Ios::GitHelper`. [#579]
- Renamed `create_release` to `create_github_release` for consistency. [#585, #588]
- Deleted the following deprecated actions: [#577, #579, #586]
- `android_betabuild_prechecks`
- `android_build_prechecks`
Expand Down Expand Up @@ -46,7 +47,6 @@
### Bug Fixes

- Fix `create_release_backmerge_pull_request_action` error when creating a backmerge to a branch not yet fetched locally. [#587]
- Deprecated the `create_release` action, now renamed to `create_github_release` for consistency. [#585]

### Internal Changes

Expand Down
1 change: 1 addition & 0 deletions MIGRATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Various helper methods and actions to calculate version bumps have been deleted (see `CHANGELOG.md` for the full list). Use the `Versioning` module for any version computation or automation.
- `Fastlane::Helper:Android::GitHelper` and `Fastlane::Helper::Ios::GitHelper` have been removed. If you were using their respective `commit_version_bump` methods, you'll need to run the commit directly in your `Fastfile`, for example via Fastlane's `git_commit` action.
- `android_tag_build` and `ios_tag_build` have been removed. Our recommended workflow for tagging releases relies on GitHub creating a tag when a GitHub release is published.
- `create_release` has been removed. Use `create_github_release` instead.

## From `10.0.0` to `11.0.0`

Expand Down
11 changes: 0 additions & 11 deletions lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_github_release_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,5 @@ def self.is_supported?(platform)
true
end
end

# For backwards compatibility
class CreateReleaseAction < CreateGithubReleaseAction
def self.category
:deprecated
end

def self.deprecated_notes
"This action has been renamed `#{superclass.action_name}`"
end
end
end
end
Loading