Remove deprecated create_release in favor of create_github_release
#588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build on top of #585. Those changes were merged just recently but their context was that of a minor update, unaware that `trunk` already included a breaking change. Since we are breaking things, I'd say we might as well remove backward compatibility by forcing users that upgrade to 12.0.0 to rename `create_release` to `create_github_release`.
iangmaia
approved these changes
Sep 3, 2024
mokagio
deleted the
mokagio/remove-deprecated-create_github_release_action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to finalize 12.0.0 when I grepped for "depreacted" and realized a new deprecation landed on
trunkwhile #580 was in progress.Builds on top of
#585.
Those changes were merged just recently but their context was that of a minor update, unaware that
trunkalready included a breaking change.Since we are breaking things, I'd say we might as well remove backward compatibility by forcing users that upgrade to 12.0.0 to rename
create_releasetocreate_github_release.What does it do?
Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicable - N.A.bundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.MIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.