Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe interpolations #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix unsafe interpolations #394

wants to merge 1 commit into from

Conversation

smortex
Copy link
Member

@smortex smortex commented Aug 28, 2023

We now have puppet-lint-check_unsafe_interpolations and it detect some
issues. Fix them.

@smortex
Copy link
Member Author

smortex commented Aug 28, 2023

Unfortunately due to puppetlabs/puppet-lint-check_unsafe_interpolations#39 we are still required to disable the check.

@smortex smortex marked this pull request as ready for review August 28, 2023 21:16
We now have puppet-lint-check_unsafe_interpolations and it detect some
issues.  Fix them.
@smortex
Copy link
Member Author

smortex commented Apr 8, 2024

I updated the PR to use stdlib::shell_escape() in favor of shell_escape() (deprecated).

I also removed the comments to disable the check to avoid the false positives because:

  1. This check is not enabled by default;
  2. I opened Fix safe interpolation detection puppetlabs/puppet-lint-check_unsafe_interpolations#48 to fix the bug.

When a version of puppet-lint-check_unsafe_interpolations that can spot shell_escaped interpolations is released, we will be able to consider its inclusion at the voxpupuli level and this module should not raise any warning when this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant