Fix openldap_schema replace without attribute types #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the schema contains any attribute types before adding the relevant `replace:` lines to the replace ldif. This fixes failing updates on schemas without any attribute types.
|
Seems like static validation check is failing on some already-existing code that I didn't touch... |
smortex
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
LGTM!
Failures are handled in #394 but the check was reverted here:
puppetlabs/puppet-lint#147
smortex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the schema contains any attribute types
before adding the relevant
replace:lines to the replace ldif.This fixes failing updates on schemas without any attribute types.