Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppet-modulebuilder: test allowlist #55

Merged
merged 1 commit into from
May 27, 2024

Conversation

bastelfreak
Copy link
Member

@bastelfreak bastelfreak commented May 26, 2024

This is a test for puppetlabs/puppet-modulebuilder#79

This implements puppetlabs/puppet-specifications#157

  • By default every file is ignored
  • Only files from the official specification for puppet modules are added to the allowlist
  • support for .pdkignore, .pmtignore and .gitignore is removed

@bastelfreak
Copy link
Member Author

To properly test this, we need https://github.com/voxpupuli/puppet-example/pull/56/files.

We run the module build during acceptance tests and during a release. We need to ensure both works

@bastelfreak bastelfreak merged commit 4debf54 into voxpupuli:master May 27, 2024
16 checks passed
@bastelfreak bastelfreak deleted the pmt branch May 27, 2024 08:01
@ekohl
Copy link
Member

ekohl commented Jun 15, 2024

I'd have preferred that this wasn't merged. You can use rake module:build to create a tarball and test it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants