.pmtignore: implement module layout specification #899
Conversation
| <% if ! @configs['paths'].nil? -%> | ||
| <% @configs['paths'].each do |path| -%> | ||
| <%= path %> |
There was a problem hiding this comment.
None of our modules used that
|
I tested this by hand and run |
There was a problem hiding this comment.
Can we build this list into puppet-modulebuilder? I'm debating how though.
You could make it default, but then it'd still read .gitignore.
You could control it via some option, but we invoke it in 2 ways: release and acceptance tests. We'd need to keep that in sync.
Adding another config file for it is ugly, but enhancing the ignore file with options is ugly too.
|
It took me some testing, but puppetlabs/puppet-modulebuilder#79 implements it in the gem itself. I think in the acceptance tests we also only build the module itself? I need to check that. I think ideally we can drop support support for parsing pdkignore/pmtignore/gitignore because the specifications define all allowed directories and those are already implemented in the allowlist in puppetlabs/puppet-modulebuilder#79 |
|
I'm also testing this in puppet-example: |
puppetlabs/puppet-specifications#157 defines which files are allowed in a puppet module release. This commit basically changes the .pmtignore into an allowlist, not a denylist anymore.
|
this works almost. The problem is that we see empty directories: |
|
I raised highb/pathspec-ruby#53 |
puppetlabs/puppet-specifications#157 defines which files are allowed in a puppet module release. This commit basically changes the .pmtignore into an allowlist, not a denylist anymore.