Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format and leaks #51

Closed
wants to merge 12 commits into from
Closed

Fix format and leaks #51

wants to merge 12 commits into from

Commits on Aug 27, 2023

  1. RedfishClientPkg: fix crash on access to uninialized list variable. 

    Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    0bce286 View commit details
    Browse the repository at this point in the history

  2. RedfishClientPkg: fix access to uninitialized variable 

    This patch fixes access to uninitialized variable, causing ASSERT from
FreePool at least.

Before this patch RedfishSettingsResponse was initialized by
GetResourceByUri under 'if (JsonValue != NULL)' condition.
But freed under 'if (Private->Payload != NULL)' condition.
Thus uninitialized pointers caused ASSERT on attempt to free memory.

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    bb72491 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. RedfishClientPkg: fix leak of allocated Etag data 

    Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    18a6be2 View commit details
    Browse the repository at this point in the history

  2. RedfishClientPkg: fix memory leak during EFI variables write. 

    Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7b324eb View commit details
    Browse the repository at this point in the history

  3. RedfishClientPkg: fix misprints in Readme.md 

    Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9f4b75b View commit details
    Browse the repository at this point in the history

  4. RedfishClientPkg: spelling fixes 

    Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    bc5c4c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. RedfishClientPkg: fix format used for output __func__ 

    Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    9ff4b8d View commit details
    Browse the repository at this point in the history

  2. RedfishClientPkg: fix DEBUG macro arguments 

    Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    03f40d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. RedfishLib: remove redudant zeroing 

    Memory allocated by calloc() is filled with bytes of value zero.

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d50d3c9 View commit details
    Browse the repository at this point in the history

  2. RedfishClientPkg: RedfishFeatureUtilityLib: fix memory leaks 

    Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8ce4c06 View commit details
    Browse the repository at this point in the history

  3. RedfishClientPkg: fix memory leak 

    This patch fixes leak in RedfishExternalResourceResourceFeatureCallback
function.

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8ae39ec View commit details
    Browse the repository at this point in the history

  4. RedfishClientPkg: fix pragma pack usage 

    Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
    @ghbaccount
    ghbaccount committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5f8b57b View commit details
    Browse the repository at this point in the history