Fix format and leaks #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
This patch fixes access to uninitialized variable, causing ASSERT from FreePool at least. Before this patch RedfishSettingsResponse was initialized by GetResourceByUri under 'if (JsonValue != NULL)' condition. But freed under 'if (Private->Payload != NULL)' condition. Thus uninitialized pointers caused ASSERT on attempt to free memory. Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
ghbaccount
force-pushed
the
fix_format_and_leaks
branch
from
0bf76ee
to
5916aab
Compare
Memory allocated by calloc() is filled with bytes of value zero. Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
This patch fixes leak in RedfishExternalResourceResourceFeatureCallback function. Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
ghbaccount
force-pushed
the
fix_format_and_leaks
branch
from
5916aab
to
5f8b57b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.