Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that LUKS.has_key always returns a boolean value #1142

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Make sure that LUKS.has_key always returns a boolean value #1142

merged 1 commit into from
Jul 13, 2023

Conversation

vojtechtrefny
Copy link
Member

We don't want to return 'None' here.

Related: rhinstaller/anaconda#4873

@vojtechtrefny vojtechtrefny mentioned this pull request Jul 12, 2023
Merged
poncovka
poncovka reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Btw. I think there are three different definitions of has_key that look like this.

jkonecny12
jkonecny12 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@vojtechtrefny
Copy link
Member Author

Thanks! Btw. I think there are three different definitions of has_key that look like this.

Oh, I forgot about Stratis. Fixed, thanks.

japokorn
japokorn approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@japokorn japokorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vojtechtrefny vojtechtrefny merged commit 1428b2e into storaged-project:3.8-devel Jul 13, 2023
4 of 5 checks passed
vojtechtrefny added a commit to vojtechtrefny/anaconda that referenced this pull request Jul 19, 2023
@vojtechtrefny
tests: Fix expected value for "has_key" with latest blivet
b2c7949 
LUKS.has_key was changed to always return boolean in the latest
blivet (see storaged-project/blivet#1142)
so we need to change expected value here.
@vojtechtrefny vojtechtrefny mentioned this pull request Jul 19, 2023
Merged
VladimirSlavik pushed a commit to vojtechtrefny/anaconda that referenced this pull request Jul 21, 2023
@vojtechtrefny @VladimirSlavik
tests: Fix expected value for "has_key" with latest blivet
58cacdb 
LUKS.has_key was changed to always return boolean in the latest
blivet (see storaged-project/blivet#1142)
so we need to change expected value here.
VladimirSlavik pushed a commit to vojtechtrefny/anaconda that referenced this pull request Jul 21, 2023
@vojtechtrefny @VladimirSlavik
tests: Fix expected value for "has_key" with latest blivet
c5a2f1b 
LUKS.has_key was changed to always return boolean in the latest
blivet (see storaged-project/blivet#1142)
so we need to change expected value here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poncovka poncovka poncovka left review comments

@jkonecny12 jkonecny12 jkonecny12 approved these changes

@japokorn japokorn japokorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vojtechtrefny @jkonecny12 @poncovka @japokorn