webui: introduce dialog to unlock existing locked LUKS partitions #4873
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
/boot-iso --webui |
|
/boot-iso --webui |
KKoukiou
force-pushed
the
webui-luks
branch
2 times, most recently
from
b63fb37
to
d7504e4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
KKoukiou
force-pushed
the
webui-luks
branch
6 times, most recently
from
42b59d2
to
f5b585d
Compare
| @@ -688,6 +688,12 @@ def test_unlock_device(self, device_setup, device_teardown, format_setup): | |||
| self.storage.devicetree.populate.assert_called_once() | |||
| self.storage.devicetree.teardown_all.assert_called_once() | |||
| assert dev2.format.has_key | |||
| assert self.interface.GetFormatData("dev2") == { | |||
There was a problem hiding this comment.
Would be great to have this check also before unlocking the device to check if has_key is False.
There was a problem hiding this comment.
So before unlocking the has_key does not exist. I am also a bit confused why it's not false, but since I just parse it from blivet and I don't get something explicit there, I guessed it's correct.
There was a problem hiding this comment.
updated the test to reflect this.
There was a problem hiding this comment.
I think that it is possible that fmt.has_key returns None instead of False, so we throw it away when we prune the collected attributes. It would be great if this attribute was always there for luks formats, but in that case, that should be fixed in Blivet. @vojtechtrefny?
There was a problem hiding this comment.
It would be great if this attribute was always there for
luksformats, but in that case, that should be fixed in Blivet.
Makes sense. storaged-project/blivet#1142
| @@ -688,6 +688,12 @@ def test_unlock_device(self, device_setup, device_teardown, format_setup): | |||
| self.storage.devicetree.populate.assert_called_once() | |||
| self.storage.devicetree.teardown_all.assert_called_once() | |||
| assert dev2.format.has_key | |||
| assert self.interface.GetFormatData("dev2") == { | |||
There was a problem hiding this comment.
I think that it is possible that fmt.has_key returns None instead of False, so we throw it away when we prune the collected attributes. It would be great if this attribute was always there for luks formats, but in that case, that should be fixed in Blivet. @vojtechtrefny?
We don't want to return 'None' here. Related: rhinstaller/anaconda#4873
We don't want to return 'None' here. Related: rhinstaller/anaconda#4873
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype smoke |
This is especially useful to know if a LUKS device can be unlocked.
|
/kickstart-test --testtype smoke |
No description provided.