Sensor Monitor support #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
suggested changes
Aug 14, 2023
Junchao-Mellanox
approved these changes
Aug 24, 2023
abdosi
approved these changes
Sep 7, 2023
|
@gechiang this is enhancement so will need to go to msft repo. not sure if we can take into 202205 branch. |
Unfortunately we currently do not have a separate MSFT Repo for sonic-platform-common so there is no way to take it in that way... either it is taken up in public 202205 or someone has to create the new MSFT repo for this submodule and also work with build team to enable auto sync works which was not that easy when we did it for sonic-utilities.msft So unless it is absolutely needed, no plan to create a new msft repo for new features. |
|
new feature, no cherry pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sonic Platform common changes required as part of Voltage & Current Sensor Monitoring Feature.
Description
New base class is introduced for defining voltage and current sensors.
Chassis and Module base classes are enhanced with APIs to retrieve voltage and current sensor data from platform.
Motivation and Context
The changes are required to support the design for sensor monitoring feature as proposed in the HLD.
HLD : sonic-net/SONiC#1394
How Has This Been Tested?
Tested with CLIs for sensor monitoring.