Voltage and Current Sensors CLI #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add unit test |
Added. |
Junchao-Mellanox
suggested changes
Aug 24, 2023
|
@Junchao-Mellanox , Pls check the updates. |
abdosi
approved these changes
Sep 1, 2023
|
@gechiang we need to take this in msft repo. not sure we can take in 2022205 branch as this is enhancement. |
|
|
@abdosi , If you need this for 202305, please submit a MSFT ADO for it... |
|
enhancement. |
JunhongMao
pushed a commit
to JunhongMao/sonic-utilities
that referenced
this pull request
Oct 4, 2023
Added support for voltage and current sensor monitoring CLIs as mentioned in the feature HLD for PMON Voltage/Current Sensor Monitoring Enhancement. sonic-net/SONiC#1394 * Addressed review comments * Fix review comment * UT file * Fixed dependency for running unit test on platform common changes * Fixed standalone unit test failure * Addressed review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support for voltage and current sensor monitoring CLIs as mentioned in the feature HLD for PMON Voltage/Current Sensor Monitoring Enhancement.
sonic-net/SONiC#1394
How I did it
How to verify it
Two new CLIs are introduced for platforms.
Sample outputs are
cisco@sonic:~$ show platform volt
Sensor Voltage(mV) High TH Low TH Crit High TH Crit Low TH Warning Timestamp
VP0P75_CORE_NPU0 760 852 684 872 664 False 20230626 08:43:04
VP0P75_CORE_NPU1 759 852 684 872 664 False 20230626 08:43:04
cisco@sonic:~$ show platform curr
Sensor Current(mA) High TH Low TH Crit High TH Crit Low TH Warning Timestamp
CURR_CORE_NPU0 416 440 320 460 300 False 20230626 08:43:05
CURR_CORE_NPU1 360 440 320 460 300 False 20230626 08:43:05