Convert the tx/rx power unit to the dBm unit #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transceiver_bulk_status(). The tx/rx power unit in the eeprom is mW, and the tx/rx power unit for the API is dBm. It should be converted to the dBm in get_transceiver_bulk_status(). Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com>
the content of rx_power[x] or tx_power[x] will be "N/A"
prgeor
previously approved these changes
Aug 8, 2023
|
@chiourung can you add unit test for code-coverage? |
mihirpat1
reviewed
Aug 8, 2023
Done |
Done |
mihirpat1
approved these changes
Aug 11, 2023
prgeor
approved these changes
Aug 16, 2023
|
@yxieca @StormLiangMS can you cherry pick this fix to 202305 and 202205 |
The corresponding ADO is 15934138 |
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 3, 2023
* JIRA-SONIC-7072: Convert the tx/rx power unit to the dBm unit in get_transceiver_bulk_status(). The tx/rx power unit in the eeprom is mW, and the tx/rx power unit for the API is dBm. It should be converted to the dBm in get_transceiver_bulk_status(). Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com> --------- Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com> Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>
yxieca
pushed a commit
that referenced
this pull request
Sep 6, 2023
* JIRA-SONIC-7072: Convert the tx/rx power unit to the dBm unit in get_transceiver_bulk_status(). The tx/rx power unit in the eeprom is mW, and the tx/rx power unit for the API is dBm. It should be converted to the dBm in get_transceiver_bulk_status(). Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com> --------- Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com> Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tx/rx power unit in the eeprom is mW, and the tx/rx power unit for the API is dBm. It should be converted to the dBm in get_transceiver_bulk_status().
Signed-off-by: chiourung_huang chiourung_huang@edge-core.com