Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx/Rx power values should be rounded up to 3 decimal places #432

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Tx/Rx power values should be rounded up to 3 decimal places #432

merged 1 commit into from
Feb 1, 2024

Conversation

mihirpat1
Copy link
Contributor

@mihirpat1 mihirpat1 commented Feb 1, 2024 •
edited
Loading

Description

It seems that currently, Tx/Rx power values are not rounded to a specific decimal value. We need to round the value up to 3 decimal places.
MSFT ADO - 26621895

Following is the snippet for the same

root@sonic:/host/Inphi# sfputil show eeprom -d -p Ethernet260
Ethernet260: SFP EEPROM detected
        Application Advertisement: N/A
        Connector: LC
        Encoding: 64B/66B
        Extended Identifier: GBIC/SFP defined by two-wire interface ID
        Extended RateSelect Compliance: Unknown
        Identifier: SFP/SFP+/SFP28
        Length OM3(10m): 30.0
        Nominal Bit Rate(100Mbs): 103
        Specification compliance:
                10G Ethernet Compliance: 10GBASE-SR
                ESCON Compliance: Unknown
                Ethernet Compliance: Unknown
                Fibre Channel Link Length: Unknown
                Fibre Channel Speed: Unknown
                Fibre Channel Transmission Media: Unknown
                Fibre Channel Transmitter Technology: Unknown
                Infiniband Compliance: Unknown
                SFP+CableTechnology: Unknown
                SONET Compliance Codes: Unknown
        Vendor Date Code(YYYY-MM-DD Lot): 2014-02-08  
        Vendor Name: FINISAR CORP.  
        Vendor OUI: 00-90-65
        Vendor PN: FTLX8571D3BCL  
        Vendor Rev: A  
        Vendor SN: AR62NDY        
        MonitorData:
                RXPower: -2.1824462534753115dBm
                TXBias: 7.46mA
                TXPower: -2.069083998234198dBm
                Temperature: 24.898C
                Vcc: 3.381Volts
        ThresholdData:
                TempHighAlarm  : 78.0C
                TempHighWarning: 73.0C
                TempLowAlarm   : -13.0C
                TempLowWarning : -8.0C
                VccHighAlarm   : 3.7Volts
                VccHighWarning : 3.6Volts
                VccLowAlarm    : 2.9Volts
                VccLowWarning  : 3.0Volts
                RxPowerHighAlarm  : 0.0dBm
                RxPowerHighWarning: -1.0dBm
                RxPowerLowAlarm   : -20.0dBm
                RxPowerLowWarning : -18.013dBm
                TxBiasHighAlarm   : 13.2mA
                TxBiasHighWarning : 12.6mA
                TxBiasLowAlarm    : 4.0mA
                TxBiasLowWarning  : 5.0mA
                TxPowerHighAlarm  : 0.0dBm
                TxPowerHighWarning: -1.0dBm
                TxPowerLowAlarm   : -6.0dBm
                TxPowerLowWarning : -5.0dBm


root@sonic:/host/Inphi#

Motivation and Context

This issue was introduced with #377 wherein the function mw_to_dbm was called for different types of SFPs.
However, the function mw_to_dbm doesn't perform rounding of the values and hence, the TX and RX power show with more precision.

Hence, I have now modified the function mw_to_dbm to round values up to 3 decimal places.

How Has This Been Tested?

The commands sfputil show eeprom -d -p PORT_NAME and show interfaces transceiver eeprom -d PORT_NAME were tested on the following types of transceivers and Tx/Rx power values were ensured to be within 3 digits.

  1. CMIS
  2. QSFP28
  3. QSFP+ (40G)
  4. SFP+ (10G)

Following is the snippet of SFP+ testing

root@sonic:/home/admin# sfputil show eeprom -d -p $port_name
Ethernet256: SFP EEPROM detected
        Application Advertisement: N/A
        Connector: LC
        Encoding: 64B/66B
        Extended Identifier: GBIC/SFP defined by two-wire interface ID
        Extended RateSelect Compliance: Unknown
        Identifier: SFP/SFP+/SFP28
        Length OM3(10m): 30.0
        Nominal Bit Rate(100Mbs): 103
        Specification compliance:
                10G Ethernet Compliance: 10GBASE-SR
                ESCON Compliance: Unknown
                Ethernet Compliance: Unknown
                Fibre Channel Link Length: Unknown
                Fibre Channel Speed: Unknown
                Fibre Channel Transmission Media: Unknown
                Fibre Channel Transmitter Technology: Unknown
                Infiniband Compliance: Unknown
                SFP+CableTechnology: Unknown
                SONET Compliance Codes: Unknown
        Vendor Date Code(YYYY-MM-DD Lot): 2009-06-27   
        Vendor Name: FINISAR CORP.   
        Vendor OUI: 00-90-65
        Vendor PN: FTLX8571D3BCL   
        Vendor Rev: A   
        Vendor SN: UFS073Z         
        MonitorData:
                RXPower: -1.752dBm
                TXBias: 7.486mA
                TXPower: -2.749dBm
                Temperature: 28.457C
                Vcc: 3.38Volts
        ThresholdData:
                TempHighAlarm  : 78.0C
                TempHighWarning: 73.0C
                TempLowAlarm   : -13.0C
                TempLowWarning : -8.0C
                VccHighAlarm   : 3.7Volts
                VccHighWarning : 3.6Volts
                VccLowAlarm    : 2.9Volts
                VccLowWarning  : 3.0Volts
                RxPowerHighAlarm  : 0.0dBm
                RxPowerHighWarning: -1.0dBm
                RxPowerLowAlarm   : -20.0dBm
                RxPowerLowWarning : -18.013dBm
                TxBiasHighAlarm   : 11.8mA
                TxBiasHighWarning : 10.8mA
                TxBiasLowAlarm    : 4.0mA
                TxBiasLowWarning  : 5.0mA
                TxPowerHighAlarm  : -0.8dBm
                TxPowerHighWarning: -1.8dBm
                TxPowerLowAlarm   : -6.0dBm
                TxPowerLowWarning : -5.0dBm

root@sonic:/home/admin# show interfaces transceiver eeprom -d $port_name
Ethernet256: SFP EEPROM detected
        Application Advertisement: N/A
        Connector: LC
        Encoding: 64B/66B
        Extended Identifier: GBIC/SFP defined by two-wire interface ID
        Extended RateSelect Compliance: Unknown
        Identifier: SFP/SFP+/SFP28
        Length OM3(10m): 30.0
        Nominal Bit Rate(100Mbs): 103
        Specification compliance:
                10G Ethernet Compliance: 10GBASE-SR
                ESCON Compliance: Unknown
                Ethernet Compliance: Unknown
                Fibre Channel Link Length: Unknown
                Fibre Channel Speed: Unknown
                Fibre Channel Transmission Media: Unknown
                Fibre Channel Transmitter Technology: Unknown
                Infiniband Compliance: Unknown
                SFP+CableTechnology: Unknown
                SONET Compliance Codes: Unknown
        Vendor Date Code(YYYY-MM-DD Lot): 2009-06-27   
        Vendor Name: FINISAR CORP.   
        Vendor OUI: 00-90-65
        Vendor PN: FTLX8571D3BCL   
        Vendor Rev: A   
        Vendor SN: UFS073Z         
        MonitorData:
                RXPower: -1.713dBm
                TXBias: 7.472mA
                TXPower: -2.774dBm
                Temperature: 29.371C
                Vcc: 3.38Volts
        ThresholdData:
                TempHighAlarm  : 78.0C
                TempHighWarning: 73.0C
                TempLowAlarm   : -13.0C
                TempLowWarning : -8.0C
                VccHighAlarm   : 3.7Volts
                VccHighWarning : 3.6Volts
                VccLowAlarm    : 2.9Volts
                VccLowWarning  : 3.0Volts
                RxPowerHighAlarm  : 0.0dBm
                RxPowerHighWarning: -1.0dBm
                RxPowerLowAlarm   : -20.0dBm
                RxPowerLowWarning : -18.013dBm
                TxBiasHighAlarm   : 11.8mA
                TxBiasHighWarning : 10.8mA
                TxBiasLowAlarm    : 4.0mA
                TxBiasLowWarning  : 5.0mA
                TxPowerHighAlarm  : -0.8dBm
                TxPowerHighWarning: -1.8dBm
                TxPowerLowAlarm   : -6.0dBm
                TxPowerLowWarning : -5.0dBm
root@sonic:/home/admin#

Additional Information (Optional)

@mihirpat1
Tx/Rx power values should be rounded up to 3 decimal places
daca59b 
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mihirpat1 mihirpat1 requested a review from prgeor February 1, 2024 20:34
@prgeor prgeor merged commit 538ec67 into sonic-net:master Feb 1, 2024
5 checks passed
@mihirpat1
Copy link
Contributor Author

@StormLiangMS, @yxieca - Can you please help in merging this to 202205, 202305 and 202311?
MSFT ADO - 26621895

mssonicbld pushed a commit to mssonicbld/sonic-platform-common that referenced this pull request Feb 1, 2024
@mihirpat1 @mssonicbld
Tx/Rx power values should be rounded up to 3 decimal places (sonic-ne…
2d7b8d3 
…t#432)

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mssonicbld mssonicbld mentioned this pull request Feb 1, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #433

mssonicbld pushed a commit that referenced this pull request Feb 1, 2024
@mihirpat1 @mssonicbld
Tx/Rx power values should be rounded up to 3 decimal places (#432)
7c2ad66 
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-platform-common that referenced this pull request Feb 4, 2024
@mihirpat1 @mssonicbld
Tx/Rx power values should be rounded up to 3 decimal places (sonic-ne…
44f9865 
…t#432)

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mssonicbld mssonicbld mentioned this pull request Feb 4, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #437

mssonicbld pushed a commit that referenced this pull request Feb 4, 2024
@mihirpat1 @mssonicbld
Tx/Rx power values should be rounded up to 3 decimal places (#432)
a64276a 
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prgeor prgeor prgeor approved these changes

Assignees
No one assigned
Labels
Approved for 202305 Branch Approved for 202311 Branch Bug CMIS Included in 202305 Branch Included in 202311 Branch Request for 202205 Branch Request for 202305 Branch Request for 202311 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mihirpat1 @mssonicbld @prgeor @yxieca @StormLiangMS