Try to make federation work (with reactive) #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2023
|
@jmartisk are you looking at this ? |
jmartisk
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are still problem with using federation like quarkusio/quarkus#30180, and there seems to be no progress for quite some time, I tried to get it work for me.
Now there is no need for
quarkus.smallrye-graphql.nonblocking.enabled=false. Although unis seem to work.I am absolutely not sure if reactive stuff is handled correctly, but maybe someone can take a look? @t1 @jmartisk @phillip-kruger
I tested with this quarkus app, query and variables to test via quarkus dev ui are included.
code-with-quarkus-graphqll-federation.zip (Although it is based on 2.3 since I use quarkus for testing)