Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pr version #31

Closed
wants to merge 1 commit into from
Closed

use pr version #31

wants to merge 1 commit into from

Conversation

robp94
Copy link

@robp94 robp94 commented Sep 4, 2023

No description provided.

@robp94
Copy link
Author

robp94 commented Sep 4, 2023

This works for me
image

@jmartisk
Copy link
Owner

jmartisk commented Sep 4, 2023

Oh, now I know where the problem with my testing was. With your smallrye-graphql changes, it indeed works.
The problem was that I had built my Quarkus 999-SNAPSHOT against smallrye-graphql 2.4.0-SNAPSHOT, but the code in your PR is 2.3.0-SNAPSHOT.
This is the way I generally prefer doing stuff - building a Quarkus snapshot after changing the smallrye-graphql dependency in QUARKUS-REPO/bom/application/pom.xml, rather than overriding in the application's pom.xml. For various reasons. So I'll politely refuse your PR, but big thanks, because it helped reveal what I'd been doing wrong.

So yeah sorry, my bad, your PR smallrye/smallrye-graphql#1898 seems to work. I'll have a bit of a deeper look into it tomorrow

@jmartisk jmartisk closed this Sep 4, 2023
@robp94
Copy link
Author

robp94 commented Sep 4, 2023

Yeah, no problem I do not have a good workflow with building custom versions of quarkus, so I mostly use the quick and dirty way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants