Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Test different versions of resque and redis #246

Merged
merged 5 commits into from
May 16, 2024
Merged

✅ Test different versions of resque and redis #246

merged 5 commits into from
May 16, 2024

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented May 15, 2024

Using Appraisal to generate the gemfiles.

The test matrix is huge, with 96 checks (at the latest count). But I want to drop support for older versions in a separate PR.

Using Appraisal to generate the gemfiles
While these theoretically might be useful for catching some weird
edge-case bugs, it doubles the number of CI builds.  So, instead we'll
just include a single runner for the older OS.
@nevans nevans force-pushed the appraisal branch 7 times, most recently from 90fbd9d to 25e15e8 Compare May 16, 2024 13:47
@nevans nevans marked this pull request as ready for review May 16, 2024 13:50
With a little effort, some of these could be made compatible, but...
it's really not worth the effort.  We'll be dropping support for older
versions from the next minor release anyway.
@nevans nevans merged commit 54d305c into main May 16, 2024
90 checks passed
@nevans nevans deleted the appraisal branch May 16, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant