Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test (and CI) against multiple versions of redis and resque gems #224

Closed
nevans opened this issue Nov 8, 2022 · 2 comments
Closed

Test (and CI) against multiple versions of redis and resque gems #224

nevans opened this issue Nov 8, 2022 · 2 comments

Comments

@nevans
Copy link
Collaborator

nevans commented Nov 8, 2022

We should be testing against a build matrix of redis and resque gems.

At the very least, we need our CI (GitHub actions) to add these gem versions into our build matrix.

I'm thinking the matrix should include: master, at least the last three minor releases for each, and the last prior major release (if it wasn't in the last three minor releases), and any other "interesting" releases (based on new features or deprecations) that we might decide to "support". e.g. right now that would be:

  • redis:
    • master
    • 5.0.5
    • 4.8.0
    • 4.7.1
  • resque:
    • master
    • 2.4.0
    • 2.3.0
    • 2.2.1

Additionally, we might want to schedule a weekly test with both gem's master.

It would also be nice if we had a single rake task that tested every version in the matrix (sequentially). But a rake task that simply ran with any specified versions (as specified by task parameters or env vars) would be fine too. It's not worth complicating this issue with this scope creep. (Although a PR might be accepted. 😉)

@nevans
Copy link
Collaborator Author

nevans commented Mar 17, 2023

We should be able to copy the approach used by resque-scheduler:

n.b. although I'd enjoy the rake task for running locally, I generally will only want to run the matrix in CI and I can also do what I want that with a bash one-liner. It's not worth complicating this issue with that.

@nevans
Copy link
Collaborator Author

nevans commented May 16, 2024

Fixed by #246

@nevans nevans closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant