Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOST-4684] test: add agora vote example #160

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonathandiep
Copy link
Contributor

@jonathandiep jonathandiep commented Oct 2, 2024

Description

Adds the agora vote example as part of the viability tests

Some features in this test:

  • Multiple action steps
  • Dynamic rewards (via ERC20VariableIncentive)

This PR also requires #158 but it also already contains the changes

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 32cad7d

@@ -0,0 +1,15 @@
require('dotenv').config();
const { optimism } = require('viem/chains');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any issue with using public rpc for this? lol

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only issue I can see is potentially blocking CI but not a huge deal 🤷

@jonathandiep jonathandiep changed the title [BOOST-4690] test: add agora vote example [BOOST-4684] test: add agora vote example Oct 2, 2024
args: [boostImpostor, txReceipt.blockNumber],
});

console.log({ amountOfVotes})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean up log 🪵

@mmackz
Copy link
Contributor

mmackz commented Oct 2, 2024

I think we need a changeset for the signatures packages whenever we add a new signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants