[BOOST-4684] Viability Testing for Agora Vote #120
Closed
+249
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mmackz
reviewed
Sep 25, 2024
| } from './helpers'; | ||
|
|
||
| let fixtures: Fixtures, budgets: BudgetFixtures; | ||
| // This is the zora contract we're going to push a transaction against |
There was a problem hiding this comment.
Could you update this comment to reflect the agora vote action
jonathandiep
force-pushed
the
jon/agora-vote-example
branch
from
25eccd9
to
04e8c92
Compare
sammccord
reviewed
Sep 25, 2024
| targetContract: targetContract, // The ERC20 contract we're monitoring | ||
| chainid: optimism.id, | ||
| }, | ||
| actionStepOne: eventActionStep, // Use the custom step for action |
There was a problem hiding this comment.
we can just use actionSteps: [eventActionStep]
sammccord
reviewed
Sep 25, 2024
| : parseEther('0.01'); | ||
|
|
||
| // Generate the signature using the trusted signer | ||
| const claimDataPayload = await prepareSignerValidatorClaimDataPayload({ |
There was a problem hiding this comment.
you should be able to use await boost.validator.encodeClaimData( here
jonathandiep
changed the title
|
Closing in favor of #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Please review the guidelines for contributing to this repository.
Description
Please describe your pull request
💔 Thank you!