Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Rename specs to simpler names #2365

Closed
wants to merge 4 commits into from
Closed

[Refactor] Rename specs to simpler names #2365

wants to merge 4 commits into from

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Aug 5, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vmoens
Update
d3f09ad 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2365

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures, 10 Unrelated Failures

As of commit c4ea7aa with merge base 788710f (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vmoens vmoens mentioned this pull request Aug 5, 2024
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}10$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 64.2622ms 58.3161ms 17.1479 Ops/s 17.4451 Ops/s $\color{#d91a1a}-1.70\%$
test_sync 38.9334ms 31.8616ms 31.3858 Ops/s 30.4032 Ops/s $\color{#35bf28}+3.23\%$
test_async 70.9485ms 30.0742ms 33.2510 Ops/s 33.0633 Ops/s $\color{#35bf28}+0.57\%$
test_simple 0.4800s 0.4147s 2.4116 Ops/s 2.4685 Ops/s $\color{#d91a1a}-2.30\%$
test_transformed 0.6324s 0.5695s 1.7558 Ops/s 1.8059 Ops/s $\color{#d91a1a}-2.77\%$
test_serial 1.3352s 1.2743s 0.7847 Ops/s 0.8020 Ops/s $\color{#d91a1a}-2.15\%$
test_parallel 1.1601s 1.0932s 0.9148 Ops/s 0.9160 Ops/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[True-True-True-True-True] 0.1561ms 24.8193μs 40.2912 KOps/s 39.7284 KOps/s $\color{#35bf28}+1.42\%$
test_step_mdp_speed[True-True-True-True-False] 39.3840μs 14.4867μs 69.0288 KOps/s 69.1157 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[True-True-True-False-True] 61.6660μs 14.2678μs 70.0878 KOps/s 66.1136 KOps/s $\textbf{\color{#35bf28}+6.01\%}$
test_step_mdp_speed[True-True-True-False-False] 47.1180μs 8.3272μs 120.0883 KOps/s 119.8615 KOps/s $\color{#35bf28}+0.19\%$
test_step_mdp_speed[True-True-False-True-True] 56.9370μs 26.4698μs 37.7789 KOps/s 36.4449 KOps/s $\color{#35bf28}+3.66\%$
test_step_mdp_speed[True-True-False-True-False] 55.1840μs 15.9066μs 62.8671 KOps/s 62.1099 KOps/s $\color{#35bf28}+1.22\%$
test_step_mdp_speed[True-True-False-False-True] 47.3090μs 15.7896μs 63.3326 KOps/s 62.2800 KOps/s $\color{#35bf28}+1.69\%$
test_step_mdp_speed[True-True-False-False-False] 50.4450μs 9.8108μs 101.9289 KOps/s 101.6678 KOps/s $\color{#35bf28}+0.26\%$
test_step_mdp_speed[True-False-True-True-True] 88.5700μs 27.8157μs 35.9509 KOps/s 35.1652 KOps/s $\color{#35bf28}+2.23\%$
test_step_mdp_speed[True-False-True-True-False] 57.0770μs 17.4824μs 57.2005 KOps/s 56.5276 KOps/s $\color{#35bf28}+1.19\%$
test_step_mdp_speed[True-False-True-False-True] 47.9100μs 15.6999μs 63.6946 KOps/s 62.9588 KOps/s $\color{#35bf28}+1.17\%$
test_step_mdp_speed[True-False-True-False-False] 37.9510μs 9.8077μs 101.9608 KOps/s 102.1130 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[True-False-False-True-True] 70.6720μs 29.5858μs 33.8000 KOps/s 33.7933 KOps/s $\color{#35bf28}+0.02\%$
test_step_mdp_speed[True-False-False-True-False] 54.8130μs 18.9403μs 52.7975 KOps/s 52.6576 KOps/s $\color{#35bf28}+0.27\%$
test_step_mdp_speed[True-False-False-False-True] 63.9300μs 17.1557μs 58.2896 KOps/s 57.6056 KOps/s $\color{#35bf28}+1.19\%$
test_step_mdp_speed[True-False-False-False-False] 46.2760μs 11.2102μs 89.2048 KOps/s 89.2180 KOps/s $\color{#d91a1a}-0.01\%$
test_step_mdp_speed[False-True-True-True-True] 60.5530μs 28.0998μs 35.5874 KOps/s 35.1531 KOps/s $\color{#35bf28}+1.24\%$
test_step_mdp_speed[False-True-True-True-False] 60.1530μs 17.5371μs 57.0221 KOps/s 57.4618 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[False-True-True-False-True] 81.4430μs 18.7740μs 53.2650 KOps/s 54.0057 KOps/s $\color{#d91a1a}-1.37\%$
test_step_mdp_speed[False-True-True-False-False] 42.9110μs 11.0491μs 90.5047 KOps/s 90.3170 KOps/s $\color{#35bf28}+0.21\%$
test_step_mdp_speed[False-True-False-True-True] 72.1650μs 29.6368μs 33.7418 KOps/s 33.4152 KOps/s $\color{#35bf28}+0.98\%$
test_step_mdp_speed[False-True-False-True-False] 62.8280μs 19.0787μs 52.4144 KOps/s 52.2557 KOps/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[False-True-False-False-True] 65.1720μs 19.7334μs 50.6754 KOps/s 50.4674 KOps/s $\color{#35bf28}+0.41\%$
test_step_mdp_speed[False-True-False-False-False] 38.8830μs 12.4871μs 80.0828 KOps/s 80.3866 KOps/s $\color{#d91a1a}-0.38\%$
test_step_mdp_speed[False-False-True-True-True] 3.9584ms 31.1265μs 32.1270 KOps/s 31.8877 KOps/s $\color{#35bf28}+0.75\%$
test_step_mdp_speed[False-False-True-True-False] 60.6640μs 20.4856μs 48.8147 KOps/s 48.6499 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[False-False-True-False-True] 49.5930μs 19.6886μs 50.7909 KOps/s 50.4287 KOps/s $\color{#35bf28}+0.72\%$
test_step_mdp_speed[False-False-True-False-False] 35.5770μs 12.5255μs 79.8374 KOps/s 79.7539 KOps/s $\color{#35bf28}+0.10\%$
test_step_mdp_speed[False-False-False-True-True] 88.8870μs 32.4041μs 30.8603 KOps/s 30.4945 KOps/s $\color{#35bf28}+1.20\%$
test_step_mdp_speed[False-False-False-True-False] 66.2540μs 21.9223μs 45.6156 KOps/s 45.7187 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[False-False-False-False-True] 52.1380μs 20.8528μs 47.9552 KOps/s 47.1365 KOps/s $\color{#35bf28}+1.74\%$
test_step_mdp_speed[False-False-False-False-False] 42.8100μs 13.9869μs 71.4956 KOps/s 72.4781 KOps/s $\color{#d91a1a}-1.36\%$
test_values[generalized_advantage_estimate-True-True] 9.6911ms 9.3053ms 107.4651 Ops/s 107.0593 Ops/s $\color{#35bf28}+0.38\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.5719ms 32.9305ms 30.3670 Ops/s 28.2467 Ops/s $\textbf{\color{#35bf28}+7.51\%}$
test_values[td0_return_estimate-False-False] 0.2178ms 0.1643ms 6.0870 KOps/s 6.0469 KOps/s $\color{#35bf28}+0.66\%$
test_values[td1_return_estimate-False-False] 23.5274ms 23.0110ms 43.4574 Ops/s 42.5544 Ops/s $\color{#35bf28}+2.12\%$
test_values[vec_td1_return_estimate-False-False] 35.7997ms 32.9920ms 30.3104 Ops/s 28.1454 Ops/s $\textbf{\color{#35bf28}+7.69\%}$
test_values[td_lambda_return_estimate-True-False] 36.9722ms 33.2662ms 30.0605 Ops/s 29.4099 Ops/s $\color{#35bf28}+2.21\%$
test_values[vec_td_lambda_return_estimate-True-False] 35.9561ms 33.0923ms 30.2185 Ops/s 28.1852 Ops/s $\textbf{\color{#35bf28}+7.21\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.3569ms 8.1485ms 122.7224 Ops/s 120.9992 Ops/s $\color{#35bf28}+1.42\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.1884ms 1.7989ms 555.8833 Ops/s 502.8849 Ops/s $\textbf{\color{#35bf28}+10.54\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4868ms 0.3584ms 2.7901 KOps/s 2.8178 KOps/s $\color{#d91a1a}-0.99\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 40.3172ms 39.5468ms 25.2865 Ops/s 22.3479 Ops/s $\textbf{\color{#35bf28}+13.15\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.0319ms 3.0215ms 330.9565 Ops/s 329.5701 Ops/s $\color{#35bf28}+0.42\%$
test_dqn_speed 6.7967ms 1.2967ms 771.2179 Ops/s 784.8341 Ops/s $\color{#d91a1a}-1.73\%$
test_ddpg_speed 3.7732ms 2.6815ms 372.9218 Ops/s 374.6104 Ops/s $\color{#d91a1a}-0.45\%$
test_sac_speed 8.1971ms 7.8323ms 127.6766 Ops/s 128.0215 Ops/s $\color{#d91a1a}-0.27\%$
test_redq_speed 13.8536ms 12.3482ms 80.9837 Ops/s 80.3450 Ops/s $\color{#35bf28}+0.79\%$
test_redq_deprec_speed 13.2144ms 12.3884ms 80.7208 Ops/s 80.4966 Ops/s $\color{#35bf28}+0.28\%$
test_td3_speed 7.9955ms 7.7252ms 129.4470 Ops/s 129.2376 Ops/s $\color{#35bf28}+0.16\%$
test_cql_speed 36.6172ms 35.0310ms 28.5462 Ops/s 27.9762 Ops/s $\color{#35bf28}+2.04\%$
test_a2c_speed 8.8053ms 7.1624ms 139.6180 Ops/s 139.2833 Ops/s $\color{#35bf28}+0.24\%$
test_ppo_speed 8.5840ms 7.4539ms 134.1576 Ops/s 134.1055 Ops/s $\color{#35bf28}+0.04\%$
test_reinforce_speed 7.5988ms 6.4228ms 155.6965 Ops/s 157.1502 Ops/s $\color{#d91a1a}-0.93\%$
test_iql_speed 33.1309ms 31.4102ms 31.8368 Ops/s 31.5697 Ops/s $\color{#35bf28}+0.85\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.8645ms 4.7185ms 211.9297 Ops/s 214.0078 Ops/s $\color{#d91a1a}-0.97\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6874ms 0.4692ms 2.1311 KOps/s 2.1240 KOps/s $\color{#35bf28}+0.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6109ms 0.4444ms 2.2503 KOps/s 2.2000 KOps/s $\color{#35bf28}+2.29\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.6066ms 4.7360ms 211.1484 Ops/s 213.3036 Ops/s $\color{#d91a1a}-1.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7306ms 0.4638ms 2.1562 KOps/s 1.8313 KOps/s $\textbf{\color{#35bf28}+17.74\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7390ms 0.4648ms 2.1516 KOps/s 2.2826 KOps/s $\textbf{\color{#d91a1a}-5.74\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.2390ms 1.6640ms 600.9790 Ops/s 602.1667 Ops/s $\color{#d91a1a}-0.20\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.9352ms 1.5740ms 635.3152 Ops/s 631.6570 Ops/s $\color{#35bf28}+0.58\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.6519ms 4.8224ms 207.3654 Ops/s 208.0086 Ops/s $\color{#d91a1a}-0.31\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8518ms 0.6027ms 1.6593 KOps/s 1.6551 KOps/s $\color{#35bf28}+0.25\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8271ms 0.5749ms 1.7395 KOps/s 1.7336 KOps/s $\color{#35bf28}+0.34\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.6507ms 4.6581ms 214.6811 Ops/s 212.8167 Ops/s $\color{#35bf28}+0.88\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1713ms 0.4791ms 2.0874 KOps/s 2.1304 KOps/s $\color{#d91a1a}-2.02\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6065ms 0.4448ms 2.2480 KOps/s 2.2170 KOps/s $\color{#35bf28}+1.40\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.6043ms 4.6523ms 214.9459 Ops/s 215.8443 Ops/s $\color{#d91a1a}-0.42\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6386ms 0.4666ms 2.1432 KOps/s 2.1663 KOps/s $\color{#d91a1a}-1.07\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5931ms 0.4390ms 2.2778 KOps/s 2.2763 KOps/s $\color{#35bf28}+0.06\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.6878ms 4.7946ms 208.5692 Ops/s 205.4416 Ops/s $\color{#35bf28}+1.52\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9495ms 0.6032ms 1.6578 KOps/s 1.6473 KOps/s $\color{#35bf28}+0.64\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7668ms 0.5774ms 1.7320 KOps/s 1.7327 KOps/s $\color{#d91a1a}-0.04\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1206s 7.9419ms 125.9140 Ops/s 165.5816 Ops/s $\textbf{\color{#d91a1a}-23.96\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.4592ms 12.9328ms 77.3231 Ops/s 79.6683 Ops/s $\color{#d91a1a}-2.94\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.6067ms 1.0880ms 919.0927 Ops/s 872.8919 Ops/s $\textbf{\color{#35bf28}+5.29\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1019s 5.6912ms 175.7112 Ops/s 174.8277 Ops/s $\color{#35bf28}+0.51\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.8999ms 12.9097ms 77.4613 Ops/s 79.5731 Ops/s $\color{#d91a1a}-2.65\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.8209ms 1.1240ms 889.7124 Ops/s 878.0992 Ops/s $\color{#35bf28}+1.32\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1055s 5.9012ms 169.4565 Ops/s 126.6208 Ops/s $\textbf{\color{#35bf28}+33.83\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.5851ms 13.0712ms 76.5039 Ops/s 78.7784 Ops/s $\color{#d91a1a}-2.89\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.8360ms 1.2345ms 810.0416 Ops/s 749.7422 Ops/s $\textbf{\color{#35bf28}+8.04\%}$

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}8$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1062s 0.1059s 9.4465 Ops/s 9.2191 Ops/s $\color{#35bf28}+2.47\%$
test_sync 91.1211ms 89.0259ms 11.2327 Ops/s 10.3507 Ops/s $\textbf{\color{#35bf28}+8.52\%}$
test_async 0.1810s 85.3300ms 11.7192 Ops/s 11.1004 Ops/s $\textbf{\color{#35bf28}+5.57\%}$
test_single_pixels 0.1169s 0.1167s 8.5711 Ops/s 8.4462 Ops/s $\color{#35bf28}+1.48\%$
test_sync_pixels 77.8595ms 76.5576ms 13.0621 Ops/s 13.0273 Ops/s $\color{#35bf28}+0.27\%$
test_async_pixels 0.1420s 71.7397ms 13.9393 Ops/s 14.0688 Ops/s $\color{#d91a1a}-0.92\%$
test_simple 0.7590s 0.7579s 1.3195 Ops/s 1.2485 Ops/s $\textbf{\color{#35bf28}+5.69\%}$
test_transformed 1.0816s 1.0074s 0.9926 Ops/s 0.9841 Ops/s $\color{#35bf28}+0.87\%$
test_serial 2.2497s 2.1771s 0.4593 Ops/s 0.4451 Ops/s $\color{#35bf28}+3.20\%$
test_parallel 1.9414s 1.8826s 0.5312 Ops/s 0.5258 Ops/s $\color{#35bf28}+1.02\%$
test_step_mdp_speed[True-True-True-True-True] 0.3490ms 37.6086μs 26.5897 KOps/s 26.0535 KOps/s $\color{#35bf28}+2.06\%$
test_step_mdp_speed[True-True-True-True-False] 0.2064ms 20.9092μs 47.8259 KOps/s 47.0922 KOps/s $\color{#35bf28}+1.56\%$
test_step_mdp_speed[True-True-True-False-True] 43.5610μs 20.7750μs 48.1347 KOps/s 45.6497 KOps/s $\textbf{\color{#35bf28}+5.44\%}$
test_step_mdp_speed[True-True-True-False-False] 0.2212ms 11.9488μs 83.6906 KOps/s 82.9035 KOps/s $\color{#35bf28}+0.95\%$
test_step_mdp_speed[True-True-False-True-True] 61.4510μs 40.1837μs 24.8857 KOps/s 24.7843 KOps/s $\color{#35bf28}+0.41\%$
test_step_mdp_speed[True-True-False-True-False] 41.8800μs 23.0514μs 43.3814 KOps/s 43.1894 KOps/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[True-True-False-False-True] 0.2250ms 23.5496μs 42.4637 KOps/s 42.5750 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[True-True-False-False-False] 0.2216ms 14.0879μs 70.9829 KOps/s 69.8784 KOps/s $\color{#35bf28}+1.58\%$
test_step_mdp_speed[True-False-True-True-True] 0.2312ms 41.6403μs 24.0152 KOps/s 23.7827 KOps/s $\color{#35bf28}+0.98\%$
test_step_mdp_speed[True-False-True-True-False] 0.1329ms 25.3996μs 39.3708 KOps/s 39.2042 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[True-False-True-False-True] 0.2320ms 23.3140μs 42.8926 KOps/s 42.8493 KOps/s $\color{#35bf28}+0.10\%$
test_step_mdp_speed[True-False-True-False-False] 0.2033ms 14.1071μs 70.8861 KOps/s 70.0026 KOps/s $\color{#35bf28}+1.26\%$
test_step_mdp_speed[True-False-False-True-True] 72.7510μs 43.2850μs 23.1027 KOps/s 22.3556 KOps/s $\color{#35bf28}+3.34\%$
test_step_mdp_speed[True-False-False-True-False] 0.2240ms 27.3911μs 36.5083 KOps/s 35.9252 KOps/s $\color{#35bf28}+1.62\%$
test_step_mdp_speed[True-False-False-False-True] 0.2268ms 25.3627μs 39.4280 KOps/s 39.0161 KOps/s $\color{#35bf28}+1.06\%$
test_step_mdp_speed[True-False-False-False-False] 0.2003ms 16.2458μs 61.5544 KOps/s 60.9296 KOps/s $\color{#35bf28}+1.03\%$
test_step_mdp_speed[False-True-True-True-True] 64.9500μs 41.3333μs 24.1936 KOps/s 23.5648 KOps/s $\color{#35bf28}+2.67\%$
test_step_mdp_speed[False-True-True-True-False] 0.2215ms 25.3200μs 39.4945 KOps/s 39.3496 KOps/s $\color{#35bf28}+0.37\%$
test_step_mdp_speed[False-True-True-False-True] 0.2144ms 27.5465μs 36.3022 KOps/s 35.6937 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[False-True-True-False-False] 0.2157ms 15.8952μs 62.9122 KOps/s 62.4453 KOps/s $\color{#35bf28}+0.75\%$
test_step_mdp_speed[False-True-False-True-True] 62.8810μs 43.5615μs 22.9561 KOps/s 22.4884 KOps/s $\color{#35bf28}+2.08\%$
test_step_mdp_speed[False-True-False-True-False] 0.2313ms 27.4276μs 36.4596 KOps/s 36.1833 KOps/s $\color{#35bf28}+0.76\%$
test_step_mdp_speed[False-True-False-False-True] 0.2321ms 29.8188μs 33.5359 KOps/s 33.0639 KOps/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[False-True-False-False-False] 0.2051ms 18.0993μs 55.2506 KOps/s 55.1080 KOps/s $\color{#35bf28}+0.26\%$
test_step_mdp_speed[False-False-True-True-True] 4.1591ms 46.6052μs 21.4568 KOps/s 20.8217 KOps/s $\color{#35bf28}+3.05\%$
test_step_mdp_speed[False-False-True-True-False] 0.2289ms 29.9474μs 33.3919 KOps/s 32.8059 KOps/s $\color{#35bf28}+1.79\%$
test_step_mdp_speed[False-False-True-False-True] 0.2491ms 29.4063μs 34.0063 KOps/s 32.8044 KOps/s $\color{#35bf28}+3.66\%$
test_step_mdp_speed[False-False-True-False-False] 0.2167ms 18.1386μs 55.1309 KOps/s 54.9131 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[False-False-False-True-True] 0.2162ms 47.7048μs 20.9622 KOps/s 20.3971 KOps/s $\color{#35bf28}+2.77\%$
test_step_mdp_speed[False-False-False-True-False] 0.2578ms 32.0439μs 31.2072 KOps/s 30.8127 KOps/s $\color{#35bf28}+1.28\%$
test_step_mdp_speed[False-False-False-False-True] 0.2303ms 31.3441μs 31.9040 KOps/s 30.9454 KOps/s $\color{#35bf28}+3.10\%$
test_step_mdp_speed[False-False-False-False-False] 41.1600μs 20.1208μs 49.6998 KOps/s 48.9773 KOps/s $\color{#35bf28}+1.48\%$
test_values[generalized_advantage_estimate-True-True] 25.1041ms 24.5412ms 40.7479 Ops/s 41.0924 Ops/s $\color{#d91a1a}-0.84\%$
test_values[vec_generalized_advantage_estimate-True-True] 89.7827ms 2.6926ms 371.3819 Ops/s 367.6444 Ops/s $\color{#35bf28}+1.02\%$
test_values[td0_return_estimate-False-False] 92.9310μs 65.8695μs 15.1815 KOps/s 15.0141 KOps/s $\color{#35bf28}+1.12\%$
test_values[td1_return_estimate-False-False] 56.7336ms 55.1860ms 18.1205 Ops/s 18.2878 Ops/s $\color{#d91a1a}-0.91\%$
test_values[vec_td1_return_estimate-False-False] 1.4030ms 1.0880ms 919.1244 Ops/s 916.4325 Ops/s $\color{#35bf28}+0.29\%$
test_values[td_lambda_return_estimate-True-False] 88.1697ms 87.4716ms 11.4323 Ops/s 11.2045 Ops/s $\color{#35bf28}+2.03\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.4213ms 1.0824ms 923.9114 Ops/s 916.5188 Ops/s $\color{#35bf28}+0.81\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.1262ms 24.7128ms 40.4648 Ops/s 40.2985 Ops/s $\color{#35bf28}+0.41\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9352ms 0.7156ms 1.3975 KOps/s 1.3832 KOps/s $\color{#35bf28}+1.03\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.9041ms 0.6732ms 1.4855 KOps/s 1.4813 KOps/s $\color{#35bf28}+0.29\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.6187ms 1.4665ms 681.8794 Ops/s 679.5481 Ops/s $\color{#35bf28}+0.34\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9096ms 0.6860ms 1.4576 KOps/s 1.4516 KOps/s $\color{#35bf28}+0.42\%$
test_dqn_speed 1.5785ms 1.3453ms 743.3486 Ops/s 706.9163 Ops/s $\textbf{\color{#35bf28}+5.15\%}$
test_ddpg_speed 3.2718ms 2.7401ms 364.9491 Ops/s 358.3296 Ops/s $\color{#35bf28}+1.85\%$
test_sac_speed 8.1987ms 7.8812ms 126.8839 Ops/s 124.7251 Ops/s $\color{#35bf28}+1.73\%$
test_redq_speed 12.3270ms 10.2690ms 97.3802 Ops/s 96.5569 Ops/s $\color{#35bf28}+0.85\%$
test_redq_deprec_speed 0.1046s 11.9609ms 83.6057 Ops/s 92.1530 Ops/s $\textbf{\color{#d91a1a}-9.28\%}$
test_td3_speed 8.1846ms 7.8631ms 127.1763 Ops/s 125.7836 Ops/s $\color{#35bf28}+1.11\%$
test_cql_speed 27.5359ms 25.4743ms 39.2552 Ops/s 39.2587 Ops/s $-0.01\%$
test_a2c_speed 5.7505ms 5.5305ms 180.8153 Ops/s 179.4011 Ops/s $\color{#35bf28}+0.79\%$
test_ppo_speed 10.3856ms 6.0650ms 164.8796 Ops/s 169.8671 Ops/s $\color{#d91a1a}-2.94\%$
test_reinforce_speed 5.1882ms 4.5516ms 219.7044 Ops/s 222.0341 Ops/s $\color{#d91a1a}-1.05\%$
test_iql_speed 20.1566ms 19.4966ms 51.2910 Ops/s 50.4114 Ops/s $\color{#35bf28}+1.74\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.7084ms 6.4990ms 153.8706 Ops/s 150.3574 Ops/s $\color{#35bf28}+2.34\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7558ms 0.5216ms 1.9173 KOps/s 1.8921 KOps/s $\color{#35bf28}+1.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7256ms 0.5031ms 1.9877 KOps/s 1.9638 KOps/s $\color{#35bf28}+1.22\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.7425ms 6.4217ms 155.7218 Ops/s 151.9990 Ops/s $\color{#35bf28}+2.45\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.8398ms 0.5127ms 1.9506 KOps/s 1.9217 KOps/s $\color{#35bf28}+1.50\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7584ms 0.4969ms 2.0127 KOps/s 1.9969 KOps/s $\color{#35bf28}+0.79\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.4777ms 1.9933ms 501.6921 Ops/s 483.4497 Ops/s $\color{#35bf28}+3.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.1144ms 1.8978ms 526.9320 Ops/s 525.5169 Ops/s $\color{#35bf28}+0.27\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.9332ms 6.6080ms 151.3314 Ops/s 147.4512 Ops/s $\color{#35bf28}+2.63\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.3104ms 0.6675ms 1.4981 KOps/s 1.4834 KOps/s $\color{#35bf28}+1.00\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8053ms 0.6432ms 1.5547 KOps/s 1.5206 KOps/s $\color{#35bf28}+2.25\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.6654ms 6.4797ms 154.3279 Ops/s 149.9623 Ops/s $\color{#35bf28}+2.91\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4370ms 0.5178ms 1.9312 KOps/s 1.9065 KOps/s $\color{#35bf28}+1.29\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6713ms 0.4944ms 2.0227 KOps/s 1.9655 KOps/s $\color{#35bf28}+2.91\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.7696ms 6.3802ms 156.7360 Ops/s 151.7484 Ops/s $\color{#35bf28}+3.29\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7391ms 0.5123ms 1.9521 KOps/s 1.8861 KOps/s $\color{#35bf28}+3.50\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.4753ms 0.5002ms 1.9992 KOps/s 1.9368 KOps/s $\color{#35bf28}+3.22\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.1617ms 6.6576ms 150.2052 Ops/s 146.7292 Ops/s $\color{#35bf28}+2.37\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1534ms 0.6645ms 1.5048 KOps/s 1.4816 KOps/s $\color{#35bf28}+1.57\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8111ms 0.6465ms 1.5469 KOps/s 1.5425 KOps/s $\color{#35bf28}+0.28\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1311s 7.7077ms 129.7406 Ops/s 97.6868 Ops/s $\textbf{\color{#35bf28}+32.81\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.5844ms 15.6719ms 63.8084 Ops/s 62.0326 Ops/s $\color{#35bf28}+2.86\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.5853ms 1.3067ms 765.3045 Ops/s 711.1041 Ops/s $\textbf{\color{#35bf28}+7.62\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1284s 7.6626ms 130.5032 Ops/s 131.7268 Ops/s $\color{#d91a1a}-0.93\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1387s 18.1893ms 54.9774 Ops/s 62.0762 Ops/s $\textbf{\color{#d91a1a}-11.44\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.4431ms 1.2949ms 772.2840 Ops/s 719.2353 Ops/s $\textbf{\color{#35bf28}+7.38\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1271s 7.7916ms 128.3433 Ops/s 128.6474 Ops/s $\color{#d91a1a}-0.24\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.9460ms 16.0618ms 62.2593 Ops/s 61.6044 Ops/s $\color{#35bf28}+1.06\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.4440ms 1.4330ms 697.8210 Ops/s 752.7137 Ops/s $\textbf{\color{#d91a1a}-7.29\%}$

@vmoens vmoens added Tests Incomplete or broken unit tests Environments Adds or modifies an environment wrapper Data Data-related PR, will launch data-related jobs Objectives Collectors labels Aug 5, 2024
@vmoens
Update
712e911 
[ghstack-poisoned]
@vmoens
Update
a00fc64 
[ghstack-poisoned]
@vmoens
Update
c4ea7aa 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Aug 6, 2024
@vmoens
[Refactor] Rename specs to simpler names
e1ac33c 
ghstack-source-id: 42e0b380076e8cdb1f55648065f5e22d8243c371
Pull Request resolved: #2365
@vmoens vmoens closed this Aug 6, 2024
vmoens added a commit that referenced this pull request Aug 6, 2024
@vmoens
[Refactor] Rename specs to simpler names
472350c 
ghstack-source-id: 13ec2536bf19bf521acdde0cf244ac6a3a197e17
Pull Request resolved: #2365
@vmoens vmoens mentioned this pull request Aug 6, 2024
Merged
@vmoens vmoens deleted the gh/vmoens/8/head branch August 7, 2024 01:38
vmoens added a commit that referenced this pull request Aug 7, 2024
@vmoens
[Refactor] Rename specs to simpler names
daf2a26 
ghstack-source-id: 13ec2536bf19bf521acdde0cf244ac6a3a197e17
Pull Request resolved: #2365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Collectors Data Data-related PR, will launch data-related jobs Environments Adds or modifies an environment wrapper Objectives Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot