Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Rename specs to simpler names #2368

Merged
merged 23 commits into from
Aug 7, 2024
Merged

[Refactor] Rename specs to simpler names #2368

merged 23 commits into from
Aug 7, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Aug 6, 2024 •
edited
Loading

No description provided.

@vmoens
[Refactor] Rename specs to simpler names
472350c 
ghstack-source-id: 13ec2536bf19bf521acdde0cf244ac6a3a197e17
Pull Request resolved: #2365
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2368

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 2 Cancelled Jobs, 14 Unrelated Failures

As of commit 21f2ac1 with merge base 788710f (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 59.7335ms 58.6423ms 17.0525 Ops/s 16.6612 Ops/s $\color{#35bf28}+2.35\%$
test_sync 38.2283ms 32.1663ms 31.0885 Ops/s 28.9213 Ops/s $\textbf{\color{#35bf28}+7.49\%}$
test_async 50.3089ms 29.9235ms 33.4186 Ops/s 32.5264 Ops/s $\color{#35bf28}+2.74\%$
test_simple 0.4860s 0.4146s 2.4121 Ops/s 2.4006 Ops/s $\color{#35bf28}+0.48\%$
test_transformed 0.6355s 0.5762s 1.7354 Ops/s 1.7434 Ops/s $\color{#d91a1a}-0.46\%$
test_serial 1.3292s 1.2721s 0.7861 Ops/s 0.7905 Ops/s $\color{#d91a1a}-0.56\%$
test_parallel 1.1709s 1.1090s 0.9017 Ops/s 0.9076 Ops/s $\color{#d91a1a}-0.65\%$
test_step_mdp_speed[True-True-True-True-True] 0.1436ms 24.5475μs 40.7373 KOps/s 38.9398 KOps/s $\color{#35bf28}+4.62\%$
test_step_mdp_speed[True-True-True-True-False] 37.0990μs 14.3576μs 69.6496 KOps/s 68.0270 KOps/s $\color{#35bf28}+2.39\%$
test_step_mdp_speed[True-True-True-False-True] 38.7020μs 14.2402μs 70.2240 KOps/s 66.9167 KOps/s $\color{#35bf28}+4.94\%$
test_step_mdp_speed[True-True-True-False-False] 46.8080μs 8.2228μs 121.6124 KOps/s 117.7295 KOps/s $\color{#35bf28}+3.30\%$
test_step_mdp_speed[True-True-False-True-True] 80.6800μs 26.3444μs 37.9588 KOps/s 37.1402 KOps/s $\color{#35bf28}+2.20\%$
test_step_mdp_speed[True-True-False-True-False] 52.1570μs 15.8378μs 63.1400 KOps/s 61.9893 KOps/s $\color{#35bf28}+1.86\%$
test_step_mdp_speed[True-True-False-False-True] 44.3230μs 15.7436μs 63.5180 KOps/s 61.9079 KOps/s $\color{#35bf28}+2.60\%$
test_step_mdp_speed[True-True-False-False-False] 64.9110μs 9.7603μs 102.4556 KOps/s 99.4302 KOps/s $\color{#35bf28}+3.04\%$
test_step_mdp_speed[True-False-True-True-True] 73.8180μs 28.3448μs 35.2798 KOps/s 34.6734 KOps/s $\color{#35bf28}+1.75\%$
test_step_mdp_speed[True-False-True-True-False] 46.0160μs 17.5695μs 56.9169 KOps/s 56.0424 KOps/s $\color{#35bf28}+1.56\%$
test_step_mdp_speed[True-False-True-False-True] 41.9880μs 15.8319μs 63.1636 KOps/s 61.5005 KOps/s $\color{#35bf28}+2.70\%$
test_step_mdp_speed[True-False-True-False-False] 43.7010μs 9.8464μs 101.5598 KOps/s 99.0723 KOps/s $\color{#35bf28}+2.51\%$
test_step_mdp_speed[True-False-False-True-True] 70.2620μs 29.4369μs 33.9710 KOps/s 33.4617 KOps/s $\color{#35bf28}+1.52\%$
test_step_mdp_speed[True-False-False-True-False] 63.8690μs 18.8535μs 53.0405 KOps/s 52.1318 KOps/s $\color{#35bf28}+1.74\%$
test_step_mdp_speed[True-False-False-False-True] 86.0910μs 17.2112μs 58.1017 KOps/s 56.5987 KOps/s $\color{#35bf28}+2.66\%$
test_step_mdp_speed[True-False-False-False-False] 40.6560μs 11.1989μs 89.2945 KOps/s 86.9741 KOps/s $\color{#35bf28}+2.67\%$
test_step_mdp_speed[False-True-True-True-True] 70.9320μs 28.1108μs 35.5735 KOps/s 34.8551 KOps/s $\color{#35bf28}+2.06\%$
test_step_mdp_speed[False-True-True-True-False] 48.9320μs 17.4315μs 57.3674 KOps/s 56.1663 KOps/s $\color{#35bf28}+2.14\%$
test_step_mdp_speed[False-True-True-False-True] 46.6570μs 18.3857μs 54.3901 KOps/s 53.7389 KOps/s $\color{#35bf28}+1.21\%$
test_step_mdp_speed[False-True-True-False-False] 39.1930μs 10.9875μs 91.0124 KOps/s 88.3897 KOps/s $\color{#35bf28}+2.97\%$
test_step_mdp_speed[False-True-False-True-True] 67.3360μs 29.6222μs 33.7585 KOps/s 33.2731 KOps/s $\color{#35bf28}+1.46\%$
test_step_mdp_speed[False-True-False-True-False] 44.3730μs 19.0770μs 52.4192 KOps/s 51.8408 KOps/s $\color{#35bf28}+1.12\%$
test_step_mdp_speed[False-True-False-False-True] 74.5690μs 19.6397μs 50.9172 KOps/s 48.8050 KOps/s $\color{#35bf28}+4.33\%$
test_step_mdp_speed[False-True-False-False-False] 45.0040μs 12.4435μs 80.3633 KOps/s 78.8304 KOps/s $\color{#35bf28}+1.94\%$
test_step_mdp_speed[False-False-True-True-True] 3.2976ms 31.4587μs 31.7877 KOps/s 31.8060 KOps/s $\color{#d91a1a}-0.06\%$
test_step_mdp_speed[False-False-True-True-False] 55.6340μs 20.6451μs 48.4377 KOps/s 48.3146 KOps/s $\color{#35bf28}+0.25\%$
test_step_mdp_speed[False-False-True-False-True] 70.1310μs 19.9265μs 50.1845 KOps/s 49.7985 KOps/s $\color{#35bf28}+0.78\%$
test_step_mdp_speed[False-False-True-False-False] 38.9830μs 12.5430μs 79.7260 KOps/s 79.0190 KOps/s $\color{#35bf28}+0.89\%$
test_step_mdp_speed[False-False-False-True-True] 59.1800μs 32.5006μs 30.7686 KOps/s 30.5097 KOps/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[False-False-False-True-False] 74.9430μs 21.7639μs 45.9476 KOps/s 45.4010 KOps/s $\color{#35bf28}+1.20\%$
test_step_mdp_speed[False-False-False-False-True] 46.5070μs 20.8548μs 47.9505 KOps/s 46.6285 KOps/s $\color{#35bf28}+2.84\%$
test_step_mdp_speed[False-False-False-False-False] 39.7250μs 13.7356μs 72.8036 KOps/s 70.6008 KOps/s $\color{#35bf28}+3.12\%$
test_values[generalized_advantage_estimate-True-True] 10.8380ms 9.5487ms 104.7258 Ops/s 107.5915 Ops/s $\color{#d91a1a}-2.66\%$
test_values[vec_generalized_advantage_estimate-True-True] 38.1835ms 36.3708ms 27.4946 Ops/s 29.7210 Ops/s $\textbf{\color{#d91a1a}-7.49\%}$
test_values[td0_return_estimate-False-False] 0.2251ms 0.1679ms 5.9571 KOps/s 6.0421 KOps/s $\color{#d91a1a}-1.41\%$
test_values[td1_return_estimate-False-False] 26.4752ms 23.8037ms 42.0103 Ops/s 43.4505 Ops/s $\color{#d91a1a}-3.31\%$
test_values[vec_td1_return_estimate-False-False] 39.4501ms 36.4510ms 27.4341 Ops/s 29.6865 Ops/s $\textbf{\color{#d91a1a}-7.59\%}$
test_values[td_lambda_return_estimate-True-False] 37.7816ms 34.1597ms 29.2742 Ops/s 29.9951 Ops/s $\color{#d91a1a}-2.40\%$
test_values[vec_td_lambda_return_estimate-True-False] 39.2896ms 36.7061ms 27.2435 Ops/s 29.6911 Ops/s $\textbf{\color{#d91a1a}-8.24\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.1989ms 8.2778ms 120.8055 Ops/s 121.4515 Ops/s $\color{#d91a1a}-0.53\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.0310ms 1.8236ms 548.3658 Ops/s 497.9387 Ops/s $\textbf{\color{#35bf28}+10.13\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4516ms 0.3520ms 2.8411 KOps/s 2.7567 KOps/s $\color{#35bf28}+3.06\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 49.8557ms 48.5965ms 20.5776 Ops/s 25.0332 Ops/s $\textbf{\color{#d91a1a}-17.80\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.1771ms 3.0397ms 328.9794 Ops/s 328.5065 Ops/s $\color{#35bf28}+0.14\%$
test_dqn_speed 6.3726ms 1.3171ms 759.2704 Ops/s 757.1069 Ops/s $\color{#35bf28}+0.29\%$
test_ddpg_speed 3.4677ms 2.7193ms 367.7365 Ops/s 366.3494 Ops/s $\color{#35bf28}+0.38\%$
test_sac_speed 9.1680ms 8.1558ms 122.6128 Ops/s 119.9897 Ops/s $\color{#35bf28}+2.19\%$
test_redq_speed 14.3840ms 13.0091ms 76.8692 Ops/s 77.3821 Ops/s $\color{#d91a1a}-0.66\%$
test_redq_deprec_speed 14.8088ms 13.3146ms 75.1056 Ops/s 76.9070 Ops/s $\color{#d91a1a}-2.34\%$
test_td3_speed 8.3109ms 8.0005ms 124.9926 Ops/s 125.0954 Ops/s $\color{#d91a1a}-0.08\%$
test_cql_speed 37.5289ms 35.5031ms 28.1665 Ops/s 28.4002 Ops/s $\color{#d91a1a}-0.82\%$
test_a2c_speed 9.4731ms 7.3187ms 136.6358 Ops/s 138.2978 Ops/s $\color{#d91a1a}-1.20\%$
test_ppo_speed 8.2956ms 7.5606ms 132.2639 Ops/s 132.7055 Ops/s $\color{#d91a1a}-0.33\%$
test_reinforce_speed 7.7931ms 6.4229ms 155.6939 Ops/s 156.0401 Ops/s $\color{#d91a1a}-0.22\%$
test_iql_speed 33.2834ms 31.7899ms 31.4565 Ops/s 31.5019 Ops/s $\color{#d91a1a}-0.14\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.2452ms 4.8227ms 207.3514 Ops/s 209.8386 Ops/s $\color{#d91a1a}-1.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8147ms 0.4718ms 2.1196 KOps/s 2.0969 KOps/s $\color{#35bf28}+1.08\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6610ms 0.4543ms 2.2012 KOps/s 2.2079 KOps/s $\color{#d91a1a}-0.31\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.9641ms 4.6613ms 214.5335 Ops/s 210.2514 Ops/s $\color{#35bf28}+2.04\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8389ms 0.4667ms 2.1425 KOps/s 2.1051 KOps/s $\color{#35bf28}+1.78\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6528ms 0.4488ms 2.2282 KOps/s 2.2130 KOps/s $\color{#35bf28}+0.69\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.0096ms 1.6684ms 599.3748 Ops/s 595.0897 Ops/s $\color{#35bf28}+0.72\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.1366ms 1.5830ms 631.7073 Ops/s 628.7110 Ops/s $\color{#35bf28}+0.48\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.0769ms 4.8096ms 207.9161 Ops/s 200.6565 Ops/s $\color{#35bf28}+3.62\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8410ms 0.6051ms 1.6527 KOps/s 1.6130 KOps/s $\color{#35bf28}+2.46\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7532ms 0.5809ms 1.7215 KOps/s 1.6743 KOps/s $\color{#35bf28}+2.82\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.8735ms 4.6959ms 212.9499 Ops/s 203.7531 Ops/s $\color{#35bf28}+4.51\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7857ms 0.4733ms 2.1127 KOps/s 2.0594 KOps/s $\color{#35bf28}+2.59\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6707ms 0.4500ms 2.2221 KOps/s 2.1793 KOps/s $\color{#35bf28}+1.97\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.6903ms 4.6974ms 212.8844 Ops/s 203.4242 Ops/s $\color{#35bf28}+4.65\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.2187ms 0.4703ms 2.1262 KOps/s 2.0796 KOps/s $\color{#35bf28}+2.24\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6065ms 0.4442ms 2.2514 KOps/s 2.1644 KOps/s $\color{#35bf28}+4.02\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.0365ms 4.8332ms 206.9036 Ops/s 199.6346 Ops/s $\color{#35bf28}+3.64\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8456ms 0.6065ms 1.6487 KOps/s 1.2621 KOps/s $\textbf{\color{#35bf28}+30.63\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7301ms 0.5794ms 1.7259 KOps/s 1.7071 KOps/s $\color{#35bf28}+1.11\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1064s 5.7307ms 174.4987 Ops/s 164.1543 Ops/s $\textbf{\color{#35bf28}+6.30\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.7602ms 12.7068ms 78.6980 Ops/s 77.9425 Ops/s $\color{#35bf28}+0.97\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 5.9519ms 1.2250ms 816.3126 Ops/s 927.9938 Ops/s $\textbf{\color{#d91a1a}-12.03\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1015s 5.5791ms 179.2398 Ops/s 171.6754 Ops/s $\color{#35bf28}+4.41\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.8227ms 12.7784ms 78.2570 Ops/s 77.5618 Ops/s $\color{#35bf28}+0.90\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.1892ms 1.2394ms 806.8641 Ops/s 930.4954 Ops/s $\textbf{\color{#d91a1a}-13.29\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1123s 8.1275ms 123.0394 Ops/s 123.7192 Ops/s $\color{#d91a1a}-0.55\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.5271ms 12.9771ms 77.0588 Ops/s 77.3338 Ops/s $\color{#d91a1a}-0.36\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.0216ms 1.2868ms 777.1243 Ops/s 842.0076 Ops/s $\textbf{\color{#d91a1a}-7.71\%}$

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1103s 0.1079s 9.2655 Ops/s 9.2872 Ops/s $\color{#d91a1a}-0.23\%$
test_sync 94.6019ms 92.7620ms 10.7803 Ops/s 10.6354 Ops/s $\color{#35bf28}+1.36\%$
test_async 0.1755s 87.8169ms 11.3873 Ops/s 11.4736 Ops/s $\color{#d91a1a}-0.75\%$
test_single_pixels 0.1196s 0.1186s 8.4333 Ops/s 8.4499 Ops/s $\color{#d91a1a}-0.20\%$
test_sync_pixels 76.2563ms 75.0710ms 13.3207 Ops/s 12.9068 Ops/s $\color{#35bf28}+3.21\%$
test_async_pixels 0.2137s 71.0362ms 14.0773 Ops/s 13.9295 Ops/s $\color{#35bf28}+1.06\%$
test_simple 0.7649s 0.7636s 1.3095 Ops/s 1.2674 Ops/s $\color{#35bf28}+3.32\%$
test_transformed 1.0921s 1.0187s 0.9816 Ops/s 0.9890 Ops/s $\color{#d91a1a}-0.74\%$
test_serial 2.2685s 2.1954s 0.4555 Ops/s 0.4453 Ops/s $\color{#35bf28}+2.29\%$
test_parallel 1.9475s 1.9089s 0.5239 Ops/s 0.5244 Ops/s $\color{#d91a1a}-0.11\%$
test_step_mdp_speed[True-True-True-True-True] 0.1066ms 38.0328μs 26.2931 KOps/s 26.7561 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[True-True-True-True-False] 39.5010μs 21.2784μs 46.9961 KOps/s 46.8711 KOps/s $\color{#35bf28}+0.27\%$
test_step_mdp_speed[True-True-True-False-True] 42.6810μs 21.8094μs 45.8518 KOps/s 47.7243 KOps/s $\color{#d91a1a}-3.92\%$
test_step_mdp_speed[True-True-True-False-False] 31.0510μs 11.9890μs 83.4100 KOps/s 83.1680 KOps/s $\color{#35bf28}+0.29\%$
test_step_mdp_speed[True-True-False-True-True] 64.3620μs 40.7297μs 24.5521 KOps/s 25.0399 KOps/s $\color{#d91a1a}-1.95\%$
test_step_mdp_speed[True-True-False-True-False] 41.7100μs 23.5016μs 42.5503 KOps/s 42.5841 KOps/s $\color{#d91a1a}-0.08\%$
test_step_mdp_speed[True-True-False-False-True] 52.7410μs 24.3788μs 41.0192 KOps/s 42.9507 KOps/s $\color{#d91a1a}-4.50\%$
test_step_mdp_speed[True-True-False-False-False] 27.4900μs 14.1898μs 70.4729 KOps/s 69.8986 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[True-False-True-True-True] 74.9020μs 42.9815μs 23.2658 KOps/s 23.4528 KOps/s $\color{#d91a1a}-0.80\%$
test_step_mdp_speed[True-False-True-True-False] 42.0610μs 25.6353μs 39.0087 KOps/s 38.6049 KOps/s $\color{#35bf28}+1.05\%$
test_step_mdp_speed[True-False-True-False-True] 39.6810μs 24.1905μs 41.3385 KOps/s 42.5388 KOps/s $\color{#d91a1a}-2.82\%$
test_step_mdp_speed[True-False-True-False-False] 37.1900μs 14.2848μs 70.0047 KOps/s 69.5399 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[True-False-False-True-True] 71.1210μs 45.0893μs 22.1782 KOps/s 22.6143 KOps/s $\color{#d91a1a}-1.93\%$
test_step_mdp_speed[True-False-False-True-False] 44.5010μs 28.0083μs 35.7037 KOps/s 35.8606 KOps/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[True-False-False-False-True] 48.2810μs 26.0962μs 38.3198 KOps/s 38.9105 KOps/s $\color{#d91a1a}-1.52\%$
test_step_mdp_speed[True-False-False-False-False] 41.8110μs 16.4640μs 60.7386 KOps/s 60.4884 KOps/s $\color{#35bf28}+0.41\%$
test_step_mdp_speed[False-True-True-True-True] 61.5910μs 43.2493μs 23.1218 KOps/s 23.6702 KOps/s $\color{#d91a1a}-2.32\%$
test_step_mdp_speed[False-True-True-True-False] 51.4310μs 25.8841μs 38.6338 KOps/s 38.4060 KOps/s $\color{#35bf28}+0.59\%$
test_step_mdp_speed[False-True-True-False-True] 55.9610μs 28.4956μs 35.0932 KOps/s 36.2936 KOps/s $\color{#d91a1a}-3.31\%$
test_step_mdp_speed[False-True-True-False-False] 37.3900μs 16.7022μs 59.8725 KOps/s 61.3922 KOps/s $\color{#d91a1a}-2.48\%$
test_step_mdp_speed[False-True-False-True-True] 64.9410μs 45.3673μs 22.0423 KOps/s 22.4573 KOps/s $\color{#d91a1a}-1.85\%$
test_step_mdp_speed[False-True-False-True-False] 64.9710μs 28.1315μs 35.5474 KOps/s 35.5931 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[False-True-False-False-True] 54.4410μs 30.4851μs 32.8029 KOps/s 33.2251 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[False-True-False-False-False] 33.7100μs 18.6133μs 53.7250 KOps/s 54.5094 KOps/s $\color{#d91a1a}-1.44\%$
test_step_mdp_speed[False-False-True-True-True] 3.9325ms 47.9298μs 20.8639 KOps/s 21.1779 KOps/s $\color{#d91a1a}-1.48\%$
test_step_mdp_speed[False-False-True-True-False] 46.9110μs 30.5794μs 32.7018 KOps/s 33.0332 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[False-False-True-False-True] 48.3210μs 30.8046μs 32.4627 KOps/s 33.4383 KOps/s $\color{#d91a1a}-2.92\%$
test_step_mdp_speed[False-False-True-False-False] 33.0410μs 18.9229μs 52.8459 KOps/s 54.0044 KOps/s $\color{#d91a1a}-2.15\%$
test_step_mdp_speed[False-False-False-True-True] 68.9810μs 49.1841μs 20.3318 KOps/s 20.5087 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[False-False-False-True-False] 51.0710μs 32.4955μs 30.7735 KOps/s 30.7861 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[False-False-False-False-True] 48.6410μs 32.4899μs 30.7788 KOps/s 31.2458 KOps/s $\color{#d91a1a}-1.49\%$
test_step_mdp_speed[False-False-False-False-False] 38.6610μs 21.0295μs 47.5522 KOps/s 49.1020 KOps/s $\color{#d91a1a}-3.16\%$
test_values[generalized_advantage_estimate-True-True] 25.4725ms 24.9702ms 40.0477 Ops/s 39.7728 Ops/s $\color{#35bf28}+0.69\%$
test_values[vec_generalized_advantage_estimate-True-True] 88.8413ms 2.6848ms 372.4609 Ops/s 357.1191 Ops/s $\color{#35bf28}+4.30\%$
test_values[td0_return_estimate-False-False] 0.1006ms 68.3184μs 14.6373 KOps/s 14.7897 KOps/s $\color{#d91a1a}-1.03\%$
test_values[td1_return_estimate-False-False] 56.5549ms 56.0648ms 17.8365 Ops/s 17.2199 Ops/s $\color{#35bf28}+3.58\%$
test_values[vec_td1_return_estimate-False-False] 1.3811ms 1.0948ms 913.3744 Ops/s 911.5255 Ops/s $\color{#35bf28}+0.20\%$
test_values[td_lambda_return_estimate-True-False] 89.6011ms 89.2000ms 11.2108 Ops/s 10.7365 Ops/s $\color{#35bf28}+4.42\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.4381ms 1.0919ms 915.8096 Ops/s 915.3402 Ops/s $\color{#35bf28}+0.05\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.1297ms 24.8876ms 40.1807 Ops/s 38.4376 Ops/s $\color{#35bf28}+4.53\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9673ms 0.7318ms 1.3664 KOps/s 1.3730 KOps/s $\color{#d91a1a}-0.48\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7619ms 0.6829ms 1.4642 KOps/s 1.4653 KOps/s $\color{#d91a1a}-0.07\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5140ms 1.4815ms 675.0095 Ops/s 675.8507 Ops/s $\color{#d91a1a}-0.12\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7292ms 0.6977ms 1.4334 KOps/s 1.4219 KOps/s $\color{#35bf28}+0.81\%$
test_dqn_speed 2.1001ms 1.3685ms 730.7018 Ops/s 725.9653 Ops/s $\color{#35bf28}+0.65\%$
test_ddpg_speed 3.0846ms 2.7560ms 362.8447 Ops/s 362.4156 Ops/s $\color{#35bf28}+0.12\%$
test_sac_speed 8.1987ms 7.9169ms 126.3125 Ops/s 127.0556 Ops/s $\color{#d91a1a}-0.58\%$
test_redq_speed 11.1402ms 10.0281ms 99.7200 Ops/s 100.3365 Ops/s $\color{#d91a1a}-0.61\%$
test_redq_deprec_speed 0.1033s 12.0140ms 83.2361 Ops/s 92.5521 Ops/s $\textbf{\color{#d91a1a}-10.07\%}$
test_td3_speed 8.0312ms 7.8958ms 126.6503 Ops/s 127.4312 Ops/s $\color{#d91a1a}-0.61\%$
test_cql_speed 25.6836ms 25.1111ms 39.8231 Ops/s 40.4324 Ops/s $\color{#d91a1a}-1.51\%$
test_a2c_speed 5.6512ms 5.4796ms 182.4953 Ops/s 181.6931 Ops/s $\color{#35bf28}+0.44\%$
test_ppo_speed 6.0563ms 5.8108ms 172.0939 Ops/s 170.8702 Ops/s $\color{#35bf28}+0.72\%$
test_reinforce_speed 5.1685ms 4.4103ms 226.7400 Ops/s 222.6573 Ops/s $\color{#35bf28}+1.83\%$
test_iql_speed 19.7078ms 19.3233ms 51.7509 Ops/s 51.6743 Ops/s $\color{#35bf28}+0.15\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.7578ms 6.6492ms 150.3946 Ops/s 149.8216 Ops/s $\color{#35bf28}+0.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6197ms 0.5093ms 1.9635 KOps/s 1.9549 KOps/s $\color{#35bf28}+0.44\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6807ms 0.4880ms 2.0491 KOps/s 2.0335 KOps/s $\color{#35bf28}+0.76\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.8050ms 6.5863ms 151.8301 Ops/s 151.4626 Ops/s $\color{#35bf28}+0.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.9152ms 0.5059ms 1.9767 KOps/s 1.9710 KOps/s $\color{#35bf28}+0.29\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6369ms 0.4849ms 2.0623 KOps/s 2.0589 KOps/s $\color{#35bf28}+0.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.1373ms 1.9495ms 512.9489 Ops/s 504.0054 Ops/s $\color{#35bf28}+1.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.0593ms 1.8551ms 539.0662 Ops/s 535.9944 Ops/s $\color{#35bf28}+0.57\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.1540ms 6.7936ms 147.1984 Ops/s 146.8911 Ops/s $\color{#35bf28}+0.21\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.6728ms 0.6936ms 1.4419 KOps/s 1.5168 KOps/s $\color{#d91a1a}-4.94\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8689ms 0.6352ms 1.5742 KOps/s 1.5798 KOps/s $\color{#d91a1a}-0.35\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.8627ms 6.6576ms 150.2032 Ops/s 149.4427 Ops/s $\color{#35bf28}+0.51\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.7342ms 0.5142ms 1.9449 KOps/s 1.9486 KOps/s $\color{#d91a1a}-0.19\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6700ms 0.4944ms 2.0225 KOps/s 2.0246 KOps/s $\color{#d91a1a}-0.10\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.7809ms 6.5393ms 152.9211 Ops/s 150.3109 Ops/s $\color{#35bf28}+1.74\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7658ms 0.5052ms 1.9796 KOps/s 1.9581 KOps/s $\color{#35bf28}+1.10\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.1905ms 0.4888ms 2.0457 KOps/s 2.0485 KOps/s $\color{#d91a1a}-0.14\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.9240ms 6.7878ms 147.3221 Ops/s 146.3756 Ops/s $\color{#35bf28}+0.65\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.2154ms 0.6585ms 1.5186 KOps/s 1.5182 KOps/s $\color{#35bf28}+0.03\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8277ms 0.6353ms 1.5740 KOps/s 1.5708 KOps/s $\color{#35bf28}+0.20\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1362s 7.7954ms 128.2806 Ops/s 97.9803 Ops/s $\textbf{\color{#35bf28}+30.92\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.9168ms 16.0860ms 62.1658 Ops/s 60.6151 Ops/s $\color{#35bf28}+2.56\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.4276ms 1.2827ms 779.6358 Ops/s 843.3044 Ops/s $\textbf{\color{#d91a1a}-7.55\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1289s 7.6786ms 130.2329 Ops/s 131.7846 Ops/s $\color{#d91a1a}-1.18\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.7085ms 16.0098ms 62.4616 Ops/s 60.7454 Ops/s $\color{#35bf28}+2.83\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.3978ms 1.2696ms 787.6588 Ops/s 741.3506 Ops/s $\textbf{\color{#35bf28}+6.25\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1273s 7.8164ms 127.9356 Ops/s 128.9170 Ops/s $\color{#d91a1a}-0.76\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1365s 18.5483ms 53.9133 Ops/s 60.1977 Ops/s $\textbf{\color{#d91a1a}-10.44\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.6404ms 1.4379ms 695.4697 Ops/s 776.8703 Ops/s $\textbf{\color{#d91a1a}-10.48\%}$

@vmoens vmoens added the Refactoring Refactoring of an existing feature label Aug 6, 2024
@vmoens vmoens mentioned this pull request Aug 6, 2024
Closed
1 task
@vmoens vmoens linked an issue Aug 7, 2024 that may be closed by this pull request
[Feature Request] Refactoring of TensorSpec and documentation #1818
Closed
1 task
@vmoens vmoens linked an issue Aug 7, 2024 that may be closed by this pull request
[BUG] Documentation of BinaryDiscreteTensorSpec can be confusing #2364
Closed
3 tasks
@vmoens vmoens merged commit c848a79 into main Aug 7, 2024
40 of 58 checks passed
vmoens added a commit that referenced this pull request Aug 7, 2024
@vmoens
[Refactor] Rename specs to simpler names (#2368)
607db8b
@vmoens vmoens deleted the refactor-specs branch August 7, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature
Projects
None yet
Milestone
No milestone
2 participants
@vmoens @facebook-github-bot