Fix unexpected loading after print
#1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
approved these changes
Nov 17, 2017
shoyer
reviewed
Nov 17, 2017
xarray/tests/test_backends.py
Outdated
| """ Make sure print does not load file into memory """ | ||
| in_memory = create_test_data() | ||
| with self.roundtrip(in_memory) as on_disk: | ||
| if not on_disk['var1']._in_memory: |
There was a problem hiding this comment.
Can we write this without the conditional check? It's usually best to avoid control flow in tests -- it makes it more obvious what is going on.
xarray/tests/test_backends.py
Outdated
| in_memory = create_test_data() | ||
| with self.roundtrip(in_memory) as on_disk: | ||
| if not on_disk['var1']._in_memory: | ||
| print(on_disk) |
There was a problem hiding this comment.
Just call repr(on_disk) to avoid actually printing to stdout.
|
@shoyer
Maybe related to your previous comment in #1705? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master **/*py | flake8 --diffwhats-new.rstfor all changes andapi.rstfor new APIOnly a single missing underscore causes this issue :)
Added tests.