Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10 Release #1535

Closed
13 tasks done
jhamman opened this issue Aug 28, 2017 · 18 comments
Closed
13 tasks done

v0.10 Release #1535

jhamman opened this issue Aug 28, 2017 · 18 comments

Comments

@jhamman
Copy link
Member

jhamman commented Aug 28, 2017

I'd like to issue the v0.10 release in within the next few weeks, after merging the following PRs:

Features

Bug Fixes

Misc

TODO

Let me know if there's anything else critical to get in.

CC @pydata/xarray

@darothen
Copy link

Great; there's only a single action item left on #1272, so I'll try to get to that later this week.

@dopplershift
Copy link
Contributor

dopplershift commented Aug 28, 2017

Can we add:

to that list?

@crusaderky
Copy link
Contributor

I'm hoping to find the time to do #1521 and #1523 too

@shoyer
Copy link
Member

shoyer commented Aug 29, 2017

@fujiisoup is finishing up #1473 (vectorized indexing) but we still have one unresolved concern: existing uses of xarray objects to index other xarray objects will break in some cases, because the behavior of vectorized indexing will depend on dimension names and coordinates on indexer objects. In particular: behavior will change if the indexer object goes along a different dimension than the corresponding dimension of the indexed object (e.g., for array.sel(x=ind) if ind.dims != ('x',)).

Unfortunately, there isn't a good way to deprecate the existing behavior while introducing the new behavior, since the meaning of this type of indexing will change. We could do a deprecation cycle (#1333), but that will mean delaying this highly useful form of indexing.

For what it's worth, I think this the last major breaking change of this type that we will need for xarray. (Though we might choose to do some other clean-ups before the v1.0 release)

Are we OK with this breaking change for the 0.10 release? It would be accompanied by a large note under "Breaking changes" in the release notes.

(Free to express your opinion with 👍 or 👎 on this comment.)

@jhamman
Copy link
Member Author

jhamman commented Sep 7, 2017

@shoyer and @fujiisoup - are we going to take care of #1333 as part of #1473?

@shoyer
Copy link
Member

shoyer commented Sep 7, 2017 via email

@shoyer
Copy link
Member

shoyer commented Oct 27, 2017

OK, I really want to get the release candidate (and the release) out promptly. #1663 in particular is going to be annoying for users with pandas 0.21 out.

I think #1615 (unicode string in netCDF3) and #1648 (vectorize=True in apply_ufunc) are ready to merge, and #1657 (warnings in test suite) is nearly so. Is there anything else we want to get in for 0.10?

The last outstanding PR from the top is #1489 (to_dask_dataframe()). I have a couple small tweaks to the design that I think we still need, but I think I'll merge it in the current state and add those tweaks in a follow-on PR.

@jhamman
Copy link
Member Author

jhamman commented Oct 27, 2017

This all sounds good to me. There is also #1485 that can go in now. We were just waiting since it has some changes to the issue template on github.

@shoyer
Copy link
Member

shoyer commented Oct 29, 2017

I think we're down to the last few PRs, all of which are nearly ready to go in:

I plan to issue the RC as soon as all of these are merged.

@jhamman
Copy link
Member Author

jhamman commented Oct 31, 2017

@shoyer - I just merged the last two PRs. We're feature complete for v0.10!

@shoyer
Copy link
Member

shoyer commented Oct 31, 2017

OK, I'm going to issue the release candidate!

@shoyer
Copy link
Member

shoyer commented Oct 31, 2017

The release candidate has been tagged and is on pypi. Docs are also up:
http://xarray.pydata.org/en/v0.10.0rc1/whats-new.html

@shoyer
Copy link
Member

shoyer commented Nov 12, 2017

We have a few more cleanup/bugfix PRs in progress that I think are almost ready to go in: #1710, #1707, #1705

I would like to merge these and then issue another release candidate.

@shoyer
Copy link
Member

shoyer commented Nov 20, 2017

The second release candidate seems to have been received well. @benbovy and @fujiisoup fixed two issues (#1723 and #1724), but neither of them were actually introduced by rc2. So I think it's time to issue the final release. I'll do so tomorrow unless there are any objections.

@shoyer
Copy link
Member

shoyer commented Nov 20, 2017

The release is tagged and on pypi: https://pypi.python.org/pypi/xarray

I'm waiting for read the docs to finish its rebuild before sending out an announcement to the mailing list.

@jhamman
Copy link
Member Author

jhamman commented Nov 20, 2017

Great. Thanks @shoyer!

@jhamman jhamman closed this as completed Nov 20, 2017
@crusaderky
Copy link
Contributor

Awesome!
Can we expect a conda build soon?

@shoyer
Copy link
Member

shoyer commented Nov 20, 2017

I just merged the update on conda-forge: conda-forge/xarray-feedstock#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants