-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Continue importing from file if single emoji import fails #14461
base: develop
Are you sure you want to change the base?
Conversation
このPRによるapi.jsonの差分 差分はこちら |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14461 +/- ##
===========================================
- Coverage 41.43% 39.67% -1.77%
===========================================
Files 1543 1539 -4
Lines 197423 191693 -5730
Branches 3603 3492 -111
===========================================
- Hits 81809 76051 -5758
- Misses 115020 115047 +27
- Partials 594 595 +1 ☔ View full report in Codecov by Sentry. |
packages/backend/src/queue/processors/ImportCustomEmojisProcessorService.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/queue/processors/ImportCustomEmojisProcessorService.ts
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
i have done so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
conflict resolved |
What
Add a try/catch block to the DriveService.addFile call to allow other emojis to be processed in the case of a missing one.
Why
There are potentially still good emojis in a file after one bad one, so interrupting the import process is bad behavior.
Additional info (optional)
Checklist
Fixes #14460