Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Continue importing from file if single emoji import fails #14461

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

winrg
Copy link
Sponsor

@winrg winrg commented Aug 25, 2024

What

Add a try/catch block to the DriveService.addFile call to allow other emojis to be processed in the case of a missing one.

Why

There are potentially still good emojis in a file after one bad one, so interrupting the import process is bad behavior.

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md

Fixes #14460

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 25, 2024
Copy link
Contributor

github-actions bot commented Aug 25, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 39.67%. Comparing base (4ac8aad) to head (2c47f2e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...e/processors/ImportCustomEmojisProcessorService.ts 0.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14461      +/-   ##
===========================================
- Coverage    41.43%   39.67%   -1.77%     
===========================================
  Files         1543     1539       -4     
  Lines       197423   191693    -5730     
  Branches      3603     3492     -111     
===========================================
- Hits         81809    76051    -5758     
- Misses      115020   115047      +27     
- Partials       594      595       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KisaragiEffective

This comment was marked as resolved.

@winrg
Copy link
Sponsor Author

winrg commented Aug 28, 2024

i have done so

Copy link
Collaborator

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 9, 2024
@kakkokari-gtyih
Copy link
Contributor

conflict resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: missing emojis in meta.json interrupts emoji import
3 participants