Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing emojis in meta.json interrupts emoji import #14460

Open
1 task done
winrg opened this issue Aug 25, 2024 · 1 comment · May be fixed by #14461
Open
1 task done

fix: missing emojis in meta.json interrupts emoji import #14460

winrg opened this issue Aug 25, 2024 · 1 comment · May be fixed by #14461
Labels
⚠️bug? This might be a bug

Comments

@winrg
Copy link
Sponsor

winrg commented Aug 25, 2024

💡 Summary

if a meta.json file in an emoji zip references a file not present in the zip, the import process will log an error and exit, interrupting the import

🥰 Expected Behavior

the remaining emojis should be imported without error

🤬 Actual Behavior

only the emojis up to the missing one are imported

📝 Steps to Reproduce

No response

💻 Frontend Environment

No response

🛰 Backend Environment (for server admin)

* Misskey: all versions back to at least commit b75184e

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@winrg winrg added the ⚠️bug? This might be a bug label Aug 25, 2024
@winrg
Copy link
Sponsor Author

winrg commented Aug 25, 2024

submitted pr #14461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant