Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change Option UI component from fluent to ant design #790

Merged
merged 10 commits into from
Apr 29, 2024

Conversation

andyhuang18
Copy link
Collaborator

@andyhuang18 andyhuang18 commented Apr 15, 2024

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

The previous project used fluent components, and I have replaced the Checkbox, Link, ChoiceGroup, and IChoiceGroupOption components with the corresponding components of antdesign. Can @wj23027 continue to revise the reconstruction of Stack components?

Checklist

Others

@andyhuang18
Copy link
Collaborator Author

Hi @wj23027 . You can replace the Stack component with the layout component in antdesign. You can refer to Flex and Grid. It should be noted that the content of Option.css may need to be adjusted.

@wxharry
Copy link
Collaborator

wxharry commented Apr 16, 2024

Do we want the colorful calendar feature in this pr?

@andyhuang18
Copy link
Collaborator Author

I found that the new branch I cut on the previous calendar branch resulted in this unrelated commit. I will try to modify it, sorry!

@wxharry
Copy link
Collaborator

wxharry commented Apr 17, 2024

I found that the new branch I cut on the previous calendar branch resulted in this unrelated commit. I will try to modify it, sorry!

No worries!

@@ -150,9 +139,9 @@ const Options = (): JSX.Element => {
</p>
<p>
GitHub:{' '}
<Link href={HYPERCRX_GITHUB} target="_blank" underline>
<a href={HYPERCRX_GITHUB} target="_blank">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be better if we use antd's Button with 'link' to replace , it would be easier to control its style and behavior. Something like this:

<Button type="text">Text</Button>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it might be more appropriate to keep the link as is?

@wxharry
Copy link
Collaborator

wxharry commented Apr 21, 2024

Nice work! Can we also replace the button with the antd Button in the src/pages/Popup/Popup.tsx? I have made that changes in this pr, so it should be an easy fix.

@andyhuang18
Copy link
Collaborator Author

Nice work! Can we also replace the button with the antd Button in the src/pages/Popup/Popup.tsx? I have made that changes in this pr, so it should be an easy fix.

Sure! I will fix this issue.

@wxharry
Copy link
Collaborator

wxharry commented Apr 23, 2024

Thanks for the contribution! This is branch is so close to get merged. Please take a look if we can remove importing @fluentui/react/lib/Icons in src/pages/Options/index.jsx. If so, remove it and remove fluentui related in package.json

@andyhuang18
Copy link
Collaborator Author

It can be said that all fluentui dependencies have been deleted. I would like to ask an additional question here. I found that there are still a large number of fluentui dependencies in yarn.lock. Do I need to delete yarn.lock and re-execute yarn install to generate a new yarn.lock?

@andyhuang18
Copy link
Collaborator Author

I found that the TooltipTrigger component also depends on fluent ui, and this part also needs to be refactored.

@andyhuang18 andyhuang18 marked this pull request as ready for review April 29, 2024 04:35
@andyhuang18
Copy link
Collaborator Author

Hi @wxharry , I have refactored all components related to fluent ui into antdesign, and now they can be merged into the main branch. @wangyantong2000 can also be developed based on the newly modified tooltip

Copy link
Member

@tyn1998 tyn1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much @andyhuang18 !

@tyn1998 tyn1998 merged commit 3b729bf into hypertrons:master Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] refactor the Options page with antd
4 participants