-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change Option UI component from fluent to ant design #790
Conversation
Do we want the colorful calendar feature in this pr? |
I found that the new branch I cut on the previous calendar branch resulted in this unrelated commit. I will try to modify it, sorry! |
ebc6c6f
to
9e88112
Compare
No worries! |
src/pages/Options/Options.tsx
Outdated
@@ -150,9 +139,9 @@ const Options = (): JSX.Element => { | |||
</p> | |||
<p> | |||
GitHub:{' '} | |||
<Link href={HYPERCRX_GITHUB} target="_blank" underline> | |||
<a href={HYPERCRX_GITHUB} target="_blank"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would be better if we use antd's Button with 'link' to replace , it would be easier to control its style and behavior. Something like this:
<Button type="text">Text</Button>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it might be more appropriate to keep the link as is?
Nice work! Can we also replace the button with the antd Button in the |
Sure! I will fix this issue. |
Thanks for the contribution! This is branch is so close to get merged. Please take a look if we can remove importing |
It can be said that all |
I found that the |
71450f0
to
02cf08d
Compare
Hi @wxharry , I have refactored all components related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you so much @andyhuang18 !
Brief Information
This pull request is in the type of (more info about types):
Related issues (all available keywords):
Details
The previous project used fluent components, and I have replaced the Checkbox, Link, ChoiceGroup, and IChoiceGroupOption components with the corresponding components of antdesign. Can @wj23027 continue to revise the reconstruction of Stack components?
Checklist
Others