Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style] improve styles in our project #693

Closed
wxharry opened this issue Jun 6, 2023 · 6 comments
Closed

[Style] improve styles in our project #693

wxharry opened this issue Jun 6, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@wxharry
Copy link
Collaborator

wxharry commented Jun 6, 2023

Description

For most of the time, our focus is on the bugs, features, and performance. However, there are some minor style problems in the style which could be fixed while working on a related feature or serve as good first issues for those who want to participate.

Please comment below about your advice on the style in the project.

@wxharry
Copy link
Collaborator Author

wxharry commented Jun 6, 2023

We should increase the bottom margin for the last box in the settings page

Before:

image

After:

image

@wxharry wxharry added the good first issue Good for newcomers label Jun 6, 2023
@stealth-bombeer
Copy link
Contributor

Hello @wxharry ,May I have a look at this ?

@wxharry
Copy link
Collaborator Author

wxharry commented Jun 6, 2023

Hello @wxharry ,May I have a look at this ?

I am glad you are interested in this. Would you please wait for others to review and add their findings so that we could fix them at once? Thanks 😄

@pranavshuklaa
Copy link
Contributor

pranavshuklaa commented Jun 7, 2023

Another style change can be for the perceptor icon .Currently, the icon appears a little light compared to the other icons in its row, this can be changed by darkening the nodes of the mesh represented by the SVG.
Before:
before

After:
image

I tested the solution on my local setup and the icon looks better after this change.

@Vlad116
Copy link
Contributor

Vlad116 commented Jun 7, 2023

I'm think we also need styled setting's button in popup, now it's look default and a little bit ugly
image

@wxharry
Copy link
Collaborator Author

wxharry commented May 9, 2024

Close as mostly fixed in #790

@wxharry wxharry closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

4 participants