Update node runners #729
Update node runners #729
Conversation
|
I was thinking we'd end Node 14 support when Node 14 goes out of LTS, which is in 1 month https://github.com/nodejs/Release#release-schedule Then we could also update the docs here https://github.com/google/wireit#requirements, and we should also be able to ship native private fields I think? |
|
+1, delaying this change until then |
|
This is ready for review. After review we'll need to drop Node 14 and 19 from the required checks in github, and add Node 20 here: https://github.com/google/wireit/settings/branch_protection_rules/25374611 |
There was a problem hiding this comment.
Nice!
WDYT about also changing the JS we emit so that this is actually breaking? We could bump up the ES level, and turn on native class fields. Could also migrate to #private class fields.
Otherwise when we eventually do rely on a newer feature, we might in practice need another breaking change, because people won't have realized that this change was the breaking one.
|
Hm, github caching tests are locking up in CI with node 20. I don't have time to debug today though. |
16 is now the most recent maintenance release, 18 the LTS and 19 the current This came up because pnpm v8 doesn't support node 14
This caught a couple of places where we could do better error handling, so it seemed worth it.
16 is now the most recent maintenance release, 18 the LTS and 20 the current
This came up because pnpm v8 doesn't support node 14
The operating system options haven't changed yet: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners