Drop node 14 and 16, emit more modern JS (#729)

* Update node runners

16 is now the most recent maintenance release, 18 the LTS and 19 the current

This came up because pnpm v8 doesn't support node 14

* Drop node 14, start testing with node 20

* Bump up tsconfig strictness

This caught a couple of places where we could do better error handling, so it seemed worth it.

* Bump up target to ES2021 as part of dropping Node 14 support.

* Update CHANGELOG and README

* Also drop support for Node 16 while we are at it.

* Convert from `private _foo` to native `#foo`

* Lint and format

* Use wireit 0.12.0 and quiet CI logger in CI

.github/workflows/tests.yml

@@ -12,21 +12,11 @@ jobs:
       # on macOS/Windows.
       matrix:
         include:
-          - node: 14
-            os: ubuntu-22.04
-          - node: 14
-            os: macos-12
-          - node: 14
-            os: windows-2022
-          - node: 16
-            os: ubuntu-22.04
           - node: 18
             os: ubuntu-22.04
-          - node: 19
-            os: ubuntu-22.04
-          - node: 19
+          - node: 18
             os: macos-12
-          - node: 19
+          - node: 18
             os: windows-2022
           - node: 20
             os: ubuntu-22.04
@@ -62,16 +52,15 @@ jobs:
 
       - run: npm ci
 
-      # Don't bother running the vscode-extension tests on Node 14, because the
-      # minimum version of VSCode we support uses Node 16.
-      - if: matrix.node == 14
-        run: npm run test:headless
-
       # See https://code.visualstudio.com/api/working-with-extensions/continuous-integration#github-actions for why we need xvfb-run
       - run: npm test
-        if: runner.os != 'Linux' && matrix.node != 14
+        if: runner.os != 'Linux'
+        env:
+          WIREIT_LOGGER: 'quiet-ci'
       - run: xvfb-run -a npm test
-        if: runner.os == 'Linux' && matrix.node != 14
+        if: runner.os == 'Linux'
+        env:
+          WIREIT_LOGGER: 'quiet-ci'
 
   lint-and-format:
     timeout-minutes: 5
@@ -80,7 +69,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: 20
           cache: npm
 
       - run: npm ci

CHANGELOG.md

@@ -8,7 +8,11 @@ Versioning](https://semver.org/spec/v2.0.0.html).
 
 <!-- ## [Unreleased] -->
 
-<!-- ## [Unreleased] -->
+## [Unreleased]
+
+### Changed
+
+- **[BREAKING]** Node 14 and Node 16 are no longer supported. Node 14 is past its end of life and Node 16 will be shortly. See the Node Release Schedule here:https://github.com/nodejs/Release#release-schedule. Node 18 will be supported until April 2025.
 
 ## [0.12.0] - 2023-09-01
 

README.md

@@ -915,12 +915,12 @@ input also affects the fingerprint:
 
 Wireit is supported on Linux, macOS, and Windows.
 
-Wireit is supported on Node Current (19), LTS (18), and Maintenance (16 and 14).
+Wireit is supported on Node Current (20), LTS (18), and Maintenance (16).
 See [Node releases](https://nodejs.org/en/about/releases/) for the schedule.
 
 > **Warning**
-> Wireit will no longer work with Node 14 when it reaches end-of-life on
-> 2023-04-30. We recommend upgrading to Node 18 as soon as possible.
+> Wireit will drop support for Node 16 soon after it reaches end-of-life on
+> 2023-09-11. We recommend upgrading to Node 20.
 
 Wireit is supported on the npm versions that ship with the latest versions of
 the above supported Node versions (6 and 8), Yarn Classic (1), Yarn Berry (3),

package.json

@@ -429,7 +429,7 @@
     "vscode-languageclient": "^8.0.1",
     "vscode-languageserver": "^8.0.1",
     "vscode-languageserver-textdocument": "^1.0.4",
-    "wireit": "^0.10.0",
+    "wireit": "^0.12.0",
     "yarn": "^1.22.18"
   },
   "prettier": {