Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a metric for machine swap capacity #3339

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

iholder101
Copy link
Contributor

@iholder101 iholder101 commented Jun 26, 2023

While for memory there are metrics for both current consumption (container_memory_usage_bytes) and total machine capacity (machine_memory_bytes), for swap memory the only supported metric is for current consumption (container_memory_swap).

This PR adds the missing piece by adding machine_swap_bytes metric that would be helpful to monitor the total amount of swap memory available on the machine.

Fixes kubernetes/kubernetes#119424

Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
@k8s-ci-robot
Copy link
Collaborator

Hi @iholder101. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 27, 2023

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KEP-2400] Determine a set of metrics for measuring node performance with swap enabled
3 participants