Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap graduates to Beta1: add a blog-post #42009

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Swap graduates to Beta1: add a blog-post #42009

merged 3 commits into from
Aug 16, 2023

Conversation

iholder101
Copy link
Contributor

@iholder101 iholder101 commented Jul 13, 2023 •
edited
Loading

Add a blog-post about Swap graduating to Beta in Kubernetes 1.28.

For more info, see: kubernetes/enhancements#4128

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @iholder101!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 13, 2023
@iholder101 iholder101 mentioned this pull request Jul 13, 2023
Open
60 tasks
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 13, 2023
@netlify
Copy link

netlify bot commented Jul 13, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0f5e17b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64d3e3502a7a2c000880e990
😎 Deploy Preview https://deploy-preview-42009--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jul 13, 2023

/sig security

Let's get this docs changed reviewed to make sure it covers all relevant information security aspects.

@k8s-ci-robot k8s-ci-robot added sig/security Categorizes an issue or PR as relevant to SIG Security. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 13, 2023
@iholder101 iholder101 changed the title Promote swap to Beta1 Swap graduates to Beta1: add a blog-post, documentation, and update feature gates Jul 19, 2023
@iholder101 iholder101 mentioned this pull request Jul 19, 2023
Closed
35 tasks
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 19, 2023
@iholder101 iholder101 marked this pull request as ready for review July 19, 2023 15:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2023
@iholder101
Copy link
Contributor Author

/cc @harche @haircommander @rphillips @SergeyKanzhelev @mrunalp

@bradmccoydev
Copy link
Member

Hello can we please put 2023-08-24 for the date of this, thanks

@sftim sftim dismissed their stale review August 8, 2023 18:28

All done bar release date

@sftim
Copy link
Contributor

sftim commented Aug 8, 2023

Thanks everyone for the work done so far.
Once the file path and front matter have the right publication date, this would be good to merge.

@iholder101 iholder101 force-pushed the docs/swap-beta1 branch 2 times, most recently from 2c4a519 to a1b7a78 Compare August 8, 2023 19:00
@iholder101
Copy link
Contributor Author

Thank you @bradmccoydev! Done.
Thanks also @sftim for all of your help, it's much appreciated!

PTAL

SergeyKanzhelev
SergeyKanzhelev reviewed Aug 8, 2023
View reviewed changes
content/en/blog/_posts/2023-08-24-swap-beta1-graduation.md Outdated

### Create a swap file and turn swap on

I'll demonstrate creating 4GiB of swap.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
I'll demonstrate creating 4GiB of swap.
I'll demonstrate creating 4GiB of unencrypted swap.

SergeyKanzhelev
SergeyKanzhelev reviewed Aug 8, 2023
View reviewed changes
content/en/blog/_posts/2023-08-24-swap-beta1-graduation.md Outdated

### Before you begin

It is required that the kubeadm tool be installed, following the steps outlined in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is required that the kubeadm tool be installed, following the steps outlined in the
It is required for this demo that the kubeadm tool be installed, following the steps outlined in the

SergeyKanzhelev
SergeyKanzhelev reviewed Aug 8, 2023
View reviewed changes
content/en/blog/_posts/2023-08-24-swap-beta1-graduation.md

Your feedback is always welcome! SIG Node [meets regularly](https://github.com/kubernetes/community/tree/master/sig-node#meetings)
and [can be reached](https://github.com/kubernetes/community/tree/master/sig-node#contact)
via [Slack](https://slack.k8s.io/) (channel **#sig-node**), or the SIG's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a swap channel in slack as well.

SergeyKanzhelev
SergeyKanzhelev approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautifully written!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 76a133481a47c49f94ffa5af275a3bf2b9915c66

@iholder101
Add a blog-post for Swap graduating to Beta
86e755d 
Signed-off-by: Itamar Holder <iholder@redhat.com>
@iholder101
Add instructions to deploy a minimal cluster with swap enabled
e881788 
Signed-off-by: Itamar Holder <iholder@redhat.com>
@iholder101
Update publish date and filename
0f5e17b 
Signed-off-by: Itamar Holder <iholder@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@iholder101
Copy link
Contributor Author

beautifully written! /lgtm

Thank you :)

Comments are addressed 👍 PTAL

@iholder101
Copy link
Contributor Author

@sftim PTAL

@sftim
Copy link
Contributor

sftim commented Aug 13, 2023

/lgtm
/approve

OK to unhold once v1.28 is released.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d25c06205789a13bea426119693d0803601420d8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, SergeyKanzhelev, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2023
@divya-mohan0209
Copy link
Contributor

Removing the hold on the PR since v1.28 has been released & the docs have been merged.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9f89239 into kubernetes:main Aug 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raesene raesene raesene left review comments

@neolit123 neolit123 neolit123 left review comments

@chendave chendave chendave left review comments

@gracenng gracenng gracenng left review comments

@mengjiao-liu mengjiao-liu mengjiao-liu left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@haircommander haircommander Awaiting requested review from haircommander

@harche harche Awaiting requested review from harche

@mrunalp mrunalp Awaiting requested review from mrunalp

@rphillips rphillips Awaiting requested review from rphillips

@pacoxu pacoxu Awaiting requested review from pacoxu

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@sftim sftim Awaiting requested review from sftim

Assignees

@pacoxu pacoxu

@SergeyKanzhelev SergeyKanzhelev

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/security Categorizes an issue or PR as relevant to SIG Security. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.