Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure sdk_moniker kwarg bug (downstream from azure-storage-blob) #425

Closed
wants to merge 2 commits into from
Closed

azure sdk_moniker kwarg bug (downstream from azure-storage-blob) #425

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
329241e
sdk_moniker
Sep 13, 2023
c996064
black ran
Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions adlfs/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,9 @@ def __init__(
sas_token: str = None,
request_session=None,
socket_timeout=_SOCKET_TIMEOUT_DEFAULT,
blocksize: int = create_configuration(storage_sdk="blob").max_block_size,
blocksize: int = create_configuration(
storage_sdk="blob", sdk_moniker="storage-blob"
).max_block_size,
client_id: str = None,
client_secret: str = None,
tenant_id: str = None,
Expand Down Expand Up @@ -285,7 +287,6 @@ def __init__(
and self.sas_token is None
and self.account_key is None
):

(
self.credential,
self.sync_credential,
Expand Down Expand Up @@ -397,7 +398,6 @@ def _get_credential_from_service_principal(self):
return (async_credential, sync_credential)

def _get_default_azure_credential(self, **kwargs):

"""
Create a Credential for authentication using DefaultAzureCredential

Expand Down
Loading