azure sdk_moniker kwarg bug (downstream from azure-storage-blob)

[benrutter]

Not sure if this is the appropriate fix or not? This PR would introduce compatibilty with azure-storage-blob version 12.18.0 which now requires sdk_moniker as a keyword argument.

For further details, see issue 424

[benrutter]

Ah, this won't actually work, sorry!

azure-storage-blob pre 12.18.0 looks like this:

config.user_agent_policy = UserAgentPolicy(
    sdk_moniker=(f"storage-{kwargs.pop('storage_skd')}/{VERSION}", **kwargs)
)

and, it now look like this:

config.user_agent_policy = UserAgentPolicy(sdk_moniker=kwargs.pop('sdk_moniker'), **kwargs)

Effectively, if you pass in sdk_moniker in a version before 12.18.0 you'll get both a dynamically generated skd_moniker, and the one you've specified.

If you don't pass it in, for version 12.18.0, you'll get an error.

So aside from doing something like figuring out which version of azure-store-blob is installed and then acting conditionally on that, I don't think it's possible to use create_configuration in a way that's consistent across versions.

If they haven't already spotted this, I'll let the azure-blob-storage project know this - I'm assuming its an accident.