Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Reverting to parallelism increases only on non-terminal phase updates #624

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Reverting to parallelism increases only on non-terminal phase updates #624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efad8e7
reverting to parallelism increases only on non-terminal phase updates
hamersaw Sep 28, 2023
b598331
Merge branch 'master' into bug/revert-max-parallelism
hamersaw Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions pkg/controller/nodes/task/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,13 +536,6 @@ func (t Handler) Handle(ctx context.Context, nCtx interfaces.NodeExecutionContex
ts := nCtx.NodeStateReader().GetTaskNodeState()

pluginTrns := &pluginRequestedTransition{}
defer func() {
// increment parallelism if the final pluginTrns is not in a terminal state
if pluginTrns != nil && !pluginTrns.pInfo.Phase().IsTerminal() {
eCtx := nCtx.ExecutionContext()
logger.Infof(ctx, "Parallelism now set to [%d].", eCtx.IncrementParallelism())
}
}()

// We will start with the assumption that catalog is disabled
pluginTrns.PopulateCacheInfo(catalog.NewFailedCatalogEntry(catalog.NewStatus(core.CatalogCacheStatus_CACHE_DISABLED, nil)))
Expand Down Expand Up @@ -667,6 +660,10 @@ func (t Handler) Handle(ctx context.Context, nCtx interfaces.NodeExecutionContex
return handler.UnknownTransition, err
}

// increment parallelism if the final pluginTrns is not in a terminal state
if pluginTrns != nil && !pluginTrns.pInfo.Phase().IsTerminal() {
logger.Infof(ctx, "Parallelism now set to [%d].", nCtx.ExecutionContext().IncrementParallelism())
}
return pluginTrns.FinalTransition(ctx)
}

Expand Down
Loading