Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Reverting to parallelism increases only on non-terminal phase updates #624

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

hamersaw
Copy link
Contributor

TL;DR

These two (1 and 2) changes attempted to fix parallelism computations. However, they introduced additional issues where now if a node in the DAG is visited multiple times in the same round it may count each time towards the parallelism. This PR reverts to previous parallelism computation (which may still be incorrect in certain scenarios).

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #624 (47ad023) into master (40fef66) will increase coverage by 0.44%.
The diff coverage is 100.00%.

❗ Current head 47ad023 differs from pull request most recent head b598331. Consider uploading reports for the commit b598331 to get more accurate results

Additional details and impacted files

@hamersaw hamersaw merged commit 0fcc1da into master Sep 29, 2023
14 checks passed
@hamersaw hamersaw deleted the bug/revert-max-parallelism branch September 29, 2023 21:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants