Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ulid instead of UUID for bulk_import #199

Closed
wants to merge 1 commit into from
Closed

ulid instead of UUID for bulk_import #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/deimos/active_record_consume/batch_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def initialize(klass:, attributes:, bulk_import_column: nil)
@klass = klass
if bulk_import_column
self.bulk_import_column = bulk_import_column
self.bulk_import_id = SecureRandom.uuid
self.bulk_import_id = ULID.generate
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/flipp-oss/deimos/blob/master/lib/deimos/active_record_consume/batch_record_list.rb#L47

This section uses select * from table where bulk_import_id in (....) . This is super slow for indexed GUID columns when table size is >300k rows. ULIDs bring in huge benefit in this context.

Do I consider making ULID part of deimos dependency OR should I define a method for calling projects to override?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not add a dependency. Providing a method to generate the ID is better IMO.

attributes[bulk_import_column] = bulk_import_id
end
attributes = attributes.with_indifferent_access
Expand Down
2 changes: 1 addition & 1 deletion lib/deimos/active_record_consume/mass_updater.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def save_records_to_database(record_list)
def import_associations(record_list)
record_list.fill_primary_keys!

import_id = @replace_associations ? SecureRandom.uuid : nil
import_id = @replace_associations ? ULID.generate : nil
record_list.associations.each do |assoc|
sub_records = record_list.map { |r| r.sub_records(assoc.name, import_id) }.flatten
next unless sub_records.any?
Expand Down
Loading