ulid instead of UUID for bulk_import

[harsha-flipp]

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added a line in the CHANGELOG describing this change, under the UNRELEASED heading
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[harsha-flipp]

https://github.com/flipp-oss/deimos/blob/master/lib/deimos/active_record_consume/batch_record_list.rb#L47

This section uses select * from table where bulk_import_id in (....) . This is super slow for indexed GUID columns when table size is >300k rows. ULIDs bring in huge benefit in this context.

Do I consider making ULID part of deimos dependency OR should I define a method for calling projects to override?

[dorner]

I'd rather not add a dependency. Providing a method to generate the ID is better IMO.

[harsha-flipp]

It's being address in different PR.