Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multicolor visualizations of large dot plot matrices #14

Merged
merged 27 commits into from
Oct 11, 2023
Merged

Conversation

fedarko
Copy link
Owner

@fedarko fedarko commented Oct 11, 2023

  • Support and benchmark the multicolor visualization of (large!) not-binary dot plot matrices using viz_spy(). Closes Support multicolor visualizations using viz_spy() #11.
  • Abstract logging to a separate file, and use it in the visualization functions.
  • Test visualization functions (mostly the logging, tbh) much more.
  • Various documentation updates.

this is actually p cool

it's a bit slower than the single-color viz, so i wanna add a param
that forces single-color viz on even nb matrices (+ doc that). but
it's cool to have this
also better doc for first comment on this
this was already noted in the part of the tutorial that generates
this figure, but let's note it in the README also
It's actually even FASTER than 50 minutes, now, but i'm sure it
will fluctuate in the future. I think being approximate makes sense.
@codecov
Copy link

codecov bot commented Oct 11, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@fedarko fedarko merged commit c478ede into main Oct 11, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multicolor visualizations using viz_spy()
1 participant