Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make matplotlib an optional dependency? #3

Open
fedarko opened this issue Aug 24, 2023 · 0 comments
Open

Make matplotlib an optional dependency? #3

fedarko opened this issue Aug 24, 2023 · 0 comments
Labels
backburner Not as brutal a designation as "wontfix", but... enhancement New feature or request

Comments

@fedarko
Copy link
Owner

fedarko commented Aug 24, 2023

Not super important, but could be nice -- since some users might just want to create these matrices without visualizing them.

That said, the tradeoff here is we'd need to put in a lot of work to check that matplotlib is available before trying to import the stuff from _viz.py, and we'd need to update the pip install explanations to say "oh yeah install it as pip install wotplot[viz] or something. This seems potentially not worth the marginal benefit of not installing matplotlib in certain cases (esp since most users will probably already have it installed anyway)...

Update: with the advent of #14, we now use matplotlib in our tests, so this is gonna be more and more difficult to set up :|

@fedarko fedarko added the enhancement New feature or request label Aug 24, 2023
@fedarko fedarko changed the title Make visualization dependencies (opencv, matplotlib) optional Make matplotlib optional Aug 29, 2023
@fedarko fedarko changed the title Make matplotlib optional Make matplotlib an optional dependency? Sep 2, 2023
@fedarko fedarko added the backburner Not as brutal a designation as "wontfix", but... label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backburner Not as brutal a designation as "wontfix", but... enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant